Re: [Qemu-devel] [PATCH 1/5] nvme: PCI/e configuration from specification

2018-09-12 Thread Eric Blake
On 9/12/18 2:53 PM, Gersner wrote: Hi Daniel, Sorry for the long round-trips, we had a busy month. We have implemented all the changes. Waiting for a final clarification. Should the new patches be posted on this thread or a new one? Best to post a v2 as a new top-level thread (our CI tools do

Re: [Qemu-devel] [PATCH 1/5] nvme: PCI/e configuration from specification

2018-09-12 Thread Gersner
Hi Daniel, Sorry for the long round-trips, we had a busy month. We have implemented all the changes. Waiting for a final clarification. Should the new patches be posted on this thread or a new one? Thanks for you time. Gersner. On Thu, Aug 30, 2018 at 6:45 PM Daniel Verkamp wrote: > Hi Shimi

Re: [Qemu-devel] [PATCH 1/5] nvme: PCI/e configuration from specification

2018-08-30 Thread Daniel Verkamp
Hi Shimi, On Sun, Aug 26, 2018 at 2:50 PM Gersner wrote: > > Hi Daniel, > Thanks for taking a look. Comments are inline. > > Gersner. > > On Sun, Jul 15, 2018 at 9:21 AM Daniel Verkamp wrote: >> >> On Fri, Jun 22, 2018 at 4:22 AM, Shimi Gersner wrote: >> > PCI/e configuration currently does not

Re: [Qemu-devel] [PATCH 1/5] nvme: PCI/e configuration from specification

2018-08-26 Thread Gersner
Hi Daniel, Thanks for taking a look. Comments are inline. Gersner. On Sun, Jul 15, 2018 at 9:21 AM Daniel Verkamp wrote: > On Fri, Jun 22, 2018 at 4:22 AM, Shimi Gersner wrote: > > PCI/e configuration currently does not meets specifications. > > > > Patch includes various configuration changes

Re: [Qemu-devel] [PATCH 1/5] nvme: PCI/e configuration from specification

2018-07-14 Thread Daniel Verkamp
On Fri, Jun 22, 2018 at 4:22 AM, Shimi Gersner wrote: > PCI/e configuration currently does not meets specifications. > > Patch includes various configuration changes to support specifications > - BAR2 to return zero when read and CMD.IOSE is not set. > - Expose NVME configuration through IO space

Re: [Qemu-devel] [PATCH 1/5] nvme: PCI/e configuration from specification

2018-07-13 Thread David Sariel
Our bad. Change-Id tag snuck into those from gerrit (https://review.gerrithub.io/c/davidsaOpenu/qemu/+/415434). Took a note to replace this line with "[PATCH v2]" but, I guess, it makes sense if additional comments will follow, right? Thanks for taking a look. On 12 July 2018 at 14:47, Kevin Wol

Re: [Qemu-devel] [PATCH 1/5] nvme: PCI/e configuration from specification

2018-07-12 Thread Kevin Wolf
Am 22.06.2018 um 13:22 hat Shimi Gersner geschrieben: > PCI/e configuration currently does not meets specifications. > > Patch includes various configuration changes to support specifications > - BAR2 to return zero when read and CMD.IOSE is not set. > - Expose NVME configuration through IO space

[Qemu-devel] [PATCH 1/5] nvme: PCI/e configuration from specification

2018-06-22 Thread Shimi Gersner
PCI/e configuration currently does not meets specifications. Patch includes various configuration changes to support specifications - BAR2 to return zero when read and CMD.IOSE is not set. - Expose NVME configuration through IO space (Optional). - PCI Power Management v1.2. - PCIe Function Level R