Re: [Qemu-devel] [PATCH 1/5] multiboot: Reject kernels exceeding the address space

2018-03-15 Thread Jack Schwartz
On 03/15/18 10:18, Kevin Wolf wrote: Am 15.03.2018 um 17:55 hat Jack Schwartz geschrieben: On 03/15/18 08:54, Kevin Wolf wrote: Am 15.03.2018 um 06:19 hat Jack Schwartz geschrieben: Hi Kevin. My comments are inline... On 2018-03-14 10:32, Kevin Wolf wrote: The code path with a manually set

Re: [Qemu-devel] [PATCH 1/5] multiboot: Reject kernels exceeding the address space

2018-03-15 Thread Kevin Wolf
Am 15.03.2018 um 17:55 hat Jack Schwartz geschrieben: > On 03/15/18 08:54, Kevin Wolf wrote: > > Am 15.03.2018 um 06:19 hat Jack Schwartz geschrieben: > > > Hi Kevin. > > > > > > My comments are inline... > > > > > > On 2018-03-14 10:32, Kevin Wolf wrote: > > > > The code path with a manually set

Re: [Qemu-devel] [PATCH 1/5] multiboot: Reject kernels exceeding the address space

2018-03-15 Thread Jack Schwartz
On 03/15/18 08:54, Kevin Wolf wrote: Am 15.03.2018 um 06:19 hat Jack Schwartz geschrieben: Hi Kevin. My comments are inline... On 2018-03-14 10:32, Kevin Wolf wrote: The code path with a manually set mh_load_addr in the Multiboot header checks that load_end_addr <= load_addr, but the path whe

Re: [Qemu-devel] [PATCH 1/5] multiboot: Reject kernels exceeding the address space

2018-03-15 Thread Kevin Wolf
Am 15.03.2018 um 06:19 hat Jack Schwartz geschrieben: > Hi Kevin. > > My comments are inline... > > On 2018-03-14 10:32, Kevin Wolf wrote: > > The code path with a manually set mh_load_addr in the Multiboot header > > checks that load_end_addr <= load_addr, but the path where load_end_addr > > is

Re: [Qemu-devel] [PATCH 1/5] multiboot: Reject kernels exceeding the address space

2018-03-14 Thread Jack Schwartz
Hi Kevin. My comments are inline... On 2018-03-14 10:32, Kevin Wolf wrote: The code path with a manually set mh_load_addr in the Multiboot header checks that load_end_addr <= load_addr, but the path where load_end_addr is automatically detected if 0 is given in the header misses the correspondi

[Qemu-devel] [PATCH 1/5] multiboot: Reject kernels exceeding the address space

2018-03-14 Thread Kevin Wolf
The code path with a manually set mh_load_addr in the Multiboot header checks that load_end_addr <= load_addr, but the path where load_end_addr is automatically detected if 0 is given in the header misses the corresponding check. If the kernel binary size is larger than can fit in the address space