Re: [Qemu-devel] [PATCH 1/5] block: Add blklogwrites

2018-06-01 Thread Eric Blake
On 06/01/2018 10:15 AM, Ari Sundholm wrote: Thank you. I'll try to get a new, more proper version of the patchset out for review/comments next week. Sorry for the sloppiness in this first version! Looking forward to it, even if, as Stefan pointed out, we can already do everything by use of t

Re: [Qemu-devel] [PATCH 1/5] block: Add blklogwrites

2018-06-01 Thread Ari Sundholm
On 06/01/2018 06:05 PM, Eric Blake wrote: On 06/01/2018 08:31 AM, Ari Sundholm wrote: +++ b/block/blklogwrites.c @@ -0,0 +1,441 @@ +/* + * Write logging blk driver based on blkverify and blkdebug. + * + * Copyright (c) 2017 Tuomas Tynkkynen + * Copyright (c) 2018 Aapo Vienamo + * Copyright (c)

Re: [Qemu-devel] [PATCH 1/5] block: Add blklogwrites

2018-06-01 Thread Eric Blake
On 06/01/2018 08:31 AM, Ari Sundholm wrote: +++ b/block/blklogwrites.c @@ -0,0 +1,441 @@ +/* + * Write logging blk driver based on blkverify and blkdebug. + * + * Copyright (c) 2017 Tuomas Tynkkynen + * Copyright (c) 2018 Aapo Vienamo + * Copyright (c) 2018 Ari Sundholm + * + * This work is li

Re: [Qemu-devel] [PATCH 1/5] block: Add blklogwrites

2018-06-01 Thread Ari Sundholm
On 06/01/2018 03:26 PM, Eric Blake wrote: On 05/31/2018 04:17 PM, Ari Sundholm wrote: From: Aapo Vienamo Implements a block device write logging system, similar to Linux kernel [meta-comment] Your patch threading is awkward - you forgot a cover letter, and then you did deep threading (ever

Re: [Qemu-devel] [PATCH 1/5] block: Add blklogwrites

2018-06-01 Thread Eric Blake
On 05/31/2018 04:17 PM, Ari Sundholm wrote: From: Aapo Vienamo Implements a block device write logging system, similar to Linux kernel [meta-comment] Your patch threading is awkward - you forgot a cover letter, and then you did deep threading (every message in-reply-to the previous) instead

[Qemu-devel] [PATCH 1/5] block: Add blklogwrites

2018-05-31 Thread Ari Sundholm
From: Aapo Vienamo Implements a block device write logging system, similar to Linux kernel device mapper dm-log-writes. The write operations that are performed on a block device are logged to a file or another block device. The write log format is identical to the dm-log-writes format. Currently,