[Qemu-devel] [PATCH 1/5] Introduce powerdown_notifiers

2012-09-05 Thread Igor Mammedov
Notifier will be used for signaling powerdown request to guest in a more general way and intended to replace very specific qemu_irq_rise(qemu_system_powerdown) and will allow to remove global variable qemu_system_powerdown. Signed-off-by: Igor Mammedov --- sysemu.h | 1 + vl.c | 8

Re: [Qemu-devel] [PATCH 1/5] introduce powerdown_notifiers

2012-08-30 Thread Igor Mammedov
On Thu, 30 Aug 2012 09:41:55 +0200 Paolo Bonzini wrote: > Il 30/08/2012 08:49, Igor Mammedov ha scritto: > >>> > > +static void qemu_system_powerdown(void) > > this is a bad naming that conflicts with global var qemu_system_powerdown, > > so > > bisectability of series is still broken. > > perha

Re: [Qemu-devel] [PATCH 1/5] introduce powerdown_notifiers

2012-08-30 Thread Paolo Bonzini
Il 30/08/2012 08:49, Igor Mammedov ha scritto: >>> > > +static void qemu_system_powerdown(void) > this is a bad naming that conflicts with global var qemu_system_powerdown, so > bisectability of series is still broken. > perhaps qemu_do_system_powerdown() would be better for function name, > althou

Re: [Qemu-devel] [PATCH 1/5] introduce powerdown_notifiers

2012-08-29 Thread Igor Mammedov
On Wed, 29 Aug 2012 19:06:45 +0200 Andreas Färber wrote: > Am 29.08.2012 19:02, schrieb Igor Mammedov: > > notifier will be used for signaling powerdown request to guest in more > > general way and intended to replace very specific > > qemu_irq_rise(qemu_system_powerdown) and will allow to remove

Re: [Qemu-devel] [PATCH 1/5] introduce powerdown_notifiers

2012-08-29 Thread Igor Mammedov
On Wed, 29 Aug 2012 19:06:45 +0200 Andreas Färber wrote: > Am 29.08.2012 19:02, schrieb Igor Mammedov: > > notifier will be used for signaling powerdown request to guest in more > > general way and intended to replace very specific > > qemu_irq_rise(qemu_system_powerdown) and will allow to remove

Re: [Qemu-devel] [PATCH 1/5] introduce powerdown_notifiers

2012-08-29 Thread Andreas Färber
Am 29.08.2012 19:02, schrieb Igor Mammedov: > notifier will be used for signaling powerdown request to guest in more > general way and intended to replace very specific > qemu_irq_rise(qemu_system_powerdown) and will allow to remove global > variable qemu_system_powerdown. > > v2: > do not make

[Qemu-devel] [PATCH 1/5] introduce powerdown_notifiers

2012-08-29 Thread Igor Mammedov
notifier will be used for signaling powerdown request to guest in more general way and intended to replace very specific qemu_irq_rise(qemu_system_powerdown) and will allow to remove global variable qemu_system_powerdown. v2: do not make qemu_system_powerdown static, spotted-by: Paolo Bonz