Re: [Qemu-devel] [PATCH 1/4] ui: add qapi parser for -display

2018-08-27 Thread Gerd Hoffmann
On Fri, Aug 24, 2018 at 08:30:23AM +0200, Markus Armbruster wrote: > Markus Armbruster writes: > > > Gerd Hoffmann writes: > > > >> Add parse_display_qapi() function which parses the -display command line > >> using a qapi visitor for DisplayOptions. Wire up as default catch in > >> parse_displ

Re: [Qemu-devel] [PATCH 1/4] ui: add qapi parser for -display

2018-08-23 Thread Gerd Hoffmann
On Fri, Aug 24, 2018 at 08:30:23AM +0200, Markus Armbruster wrote: > Markus Armbruster writes: > > > Gerd Hoffmann writes: > > > >> Add parse_display_qapi() function which parses the -display command line > >> using a qapi visitor for DisplayOptions. Wire up as default catch in > >> parse_displ

Re: [Qemu-devel] [PATCH 1/4] ui: add qapi parser for -display

2018-08-23 Thread Markus Armbruster
Markus Armbruster writes: > Gerd Hoffmann writes: > >> Add parse_display_qapi() function which parses the -display command line >> using a qapi visitor for DisplayOptions. Wire up as default catch in >> parse_display(). >> >> Improves the error message for unknown display types. >> >> Also enab

Re: [Qemu-devel] [PATCH 1/4] ui: add qapi parser for -display

2018-07-26 Thread Markus Armbruster
Gerd Hoffmann writes: > Add parse_display_qapi() function which parses the -display command line > using a qapi visitor for DisplayOptions. Wire up as default catch in > parse_display(). > > Improves the error message for unknown display types. > > Also enables json as -display argument, i.e. -d

Re: [Qemu-devel] [PATCH 1/4] ui: add qapi parser for -display

2018-04-19 Thread Gerd Hoffmann
> > +/* > > + * We don't have any dynamically allocated stuff inside > > + * DisplayOptions, so we can simply copy the struct content and > > + * free opts without ending up with pointers pointing into > > + * nowhere. > > + */ > > +dpy = *opts; > > +qapi_free_Displa

Re: [Qemu-devel] [PATCH 1/4] ui: add qapi parser for -display

2018-04-19 Thread Eric Blake
On 04/19/2018 08:20 AM, Gerd Hoffmann wrote: > Add parse_display_qapi() function which parses the -display command line > using a qapi visitor for DisplayOptions. Wire up as default catch in > parse_display(). > > Improves the error message for unknown display types. > > Also enables json as -di

[Qemu-devel] [PATCH 1/4] ui: add qapi parser for -display

2018-04-19 Thread Gerd Hoffmann
Add parse_display_qapi() function which parses the -display command line using a qapi visitor for DisplayOptions. Wire up as default catch in parse_display(). Improves the error message for unknown display types. Also enables json as -display argument, i.e. -display "{ 'type': 'gtk' }" Signed-o