Re: [Qemu-devel] [PATCH 1/4] target-ppc: Implement bcdcfsq. instruction

2016-11-17 Thread David Gibson
On Thu, Nov 17, 2016 at 03:31:48PM -0200, jos...@linux.vnet.ibm.com wrote: > Hello David, > > Thank you for your review. I have just one question below, could you > help me to address it please? > > Thank you! > > Ziviani > > On Thu, Nov 17, 2016 at 02:42:43PM +1100, David Gibson wrote: > > On

Re: [Qemu-devel] [PATCH 1/4] target-ppc: Implement bcdcfsq. instruction

2016-11-17 Thread joserz
Hello David, Thank you for your review. I have just one question below, could you help me to address it please? Thank you! Ziviani On Thu, Nov 17, 2016 at 02:42:43PM +1100, David Gibson wrote: > On Wed, Nov 16, 2016 at 06:07:27PM -0200, Jose Ricardo Ziviani wrote: > > bcdcfsq.: Decimal convert

Re: [Qemu-devel] [PATCH 1/4] target-ppc: Implement bcdcfsq. instruction

2016-11-16 Thread David Gibson
On Wed, Nov 16, 2016 at 06:07:27PM -0200, Jose Ricardo Ziviani wrote: > bcdcfsq.: Decimal convert from signed quadword. It is possible to I think there should be a "not" in there. > convert values less than 10^31-1 or greater than -10^31-1 to be > represented in packed decimal format. > > Signed

[Qemu-devel] [PATCH 1/4] target-ppc: Implement bcdcfsq. instruction

2016-11-16 Thread Jose Ricardo Ziviani
bcdcfsq.: Decimal convert from signed quadword. It is possible to convert values less than 10^31-1 or greater than -10^31-1 to be represented in packed decimal format. Signed-off-by: Jose Ricardo Ziviani --- target-ppc/helper.h | 1 + target-ppc/int_helper.c | 48 +++