Re: [Qemu-devel] [PATCH 1/4] slirp: Fix restricted mode

2011-05-24 Thread Jan Kiszka
On 2011-05-24 16:37, Gleb Natapov wrote: > On Tue, May 24, 2011 at 03:34:33PM +0200, Jan Kiszka wrote: >> On 2011-05-24 15:01, Gleb Natapov wrote: >>> On Tue, May 24, 2011 at 02:42:55PM +0200, Jan Kiszka wrote: On 2011-05-24 14:37, Gleb Natapov wrote: > On Mon, May 23, 2011 at 04:48:16PM +

Re: [Qemu-devel] [PATCH 1/4] slirp: Fix restricted mode

2011-05-24 Thread Gleb Natapov
On Tue, May 24, 2011 at 03:34:33PM +0200, Jan Kiszka wrote: > On 2011-05-24 15:01, Gleb Natapov wrote: > > On Tue, May 24, 2011 at 02:42:55PM +0200, Jan Kiszka wrote: > >> On 2011-05-24 14:37, Gleb Natapov wrote: > >>> On Mon, May 23, 2011 at 04:48:16PM +0200, Jan Kiszka wrote: > This aligns t

Re: [Qemu-devel] [PATCH 1/4] slirp: Fix restricted mode

2011-05-24 Thread Jan Kiszka
On 2011-05-24 15:01, Gleb Natapov wrote: > On Tue, May 24, 2011 at 02:42:55PM +0200, Jan Kiszka wrote: >> On 2011-05-24 14:37, Gleb Natapov wrote: >>> On Mon, May 23, 2011 at 04:48:16PM +0200, Jan Kiszka wrote: This aligns the code to what the documentation claims: Allow everything but re

Re: [Qemu-devel] [PATCH 1/4] slirp: Fix restricted mode

2011-05-24 Thread Gleb Natapov
On Tue, May 24, 2011 at 02:42:55PM +0200, Jan Kiszka wrote: > On 2011-05-24 14:37, Gleb Natapov wrote: > > On Mon, May 23, 2011 at 04:48:16PM +0200, Jan Kiszka wrote: > >> This aligns the code to what the documentation claims: Allow everything > >> but requests that would have to be routed outside

Re: [Qemu-devel] [PATCH 1/4] slirp: Fix restricted mode

2011-05-24 Thread Jan Kiszka
On 2011-05-24 14:37, Gleb Natapov wrote: > On Mon, May 23, 2011 at 04:48:16PM +0200, Jan Kiszka wrote: >> This aligns the code to what the documentation claims: Allow everything >> but requests that would have to be routed outside of the virtual LAN. >> >> So we need to drop the unneeded IP-level f

Re: [Qemu-devel] [PATCH 1/4] slirp: Fix restricted mode

2011-05-24 Thread Gleb Natapov
On Mon, May 23, 2011 at 04:48:16PM +0200, Jan Kiszka wrote: > This aligns the code to what the documentation claims: Allow everything > but requests that would have to be routed outside of the virtual LAN. > > So we need to drop the unneeded IP-level filter, allow TFTP requests, > and add the miss

[Qemu-devel] [PATCH 1/4] slirp: Fix restricted mode

2011-05-23 Thread Jan Kiszka
This aligns the code to what the documentation claims: Allow everything but requests that would have to be routed outside of the virtual LAN. So we need to drop the unneeded IP-level filter, allow TFTP requests, and add the missing protocol-level filter to ICMP. CC: Gleb Natapov Signed-off-by: J