Re: [Qemu-devel] [PATCH 1/4] scsi-generic: keep VPD page list sorted

2018-11-06 Thread Daniel Henrique Barboza
On 10/29/18 2:34 PM, Paolo Bonzini wrote: Block limits emulation is just placing 0xb0 as the final byte of the VPD pages list. However, VPD page numbers must be sorted, so change that to an in-place insert. Since I couldn't find any disk that triggered the loop more than once, this was teste

Re: [Qemu-devel] [PATCH 1/4] scsi-generic: keep VPD page list sorted

2018-11-05 Thread Max Reitz
On 29.10.18 18:34, Paolo Bonzini wrote: > Block limits emulation is just placing 0xb0 as the final byte of the > VPD pages list. However, VPD page numbers must be sorted, so change > that to an in-place insert. Since I couldn't find any disk that triggered > the loop more than once, this was test

[Qemu-devel] [PATCH 1/4] scsi-generic: keep VPD page list sorted

2018-10-29 Thread Paolo Bonzini
Block limits emulation is just placing 0xb0 as the final byte of the VPD pages list. However, VPD page numbers must be sorted, so change that to an in-place insert. Since I couldn't find any disk that triggered the loop more than once, this was tested by adding manually 0xb1 at the end of the lis