Re: [Qemu-devel] [PATCH 1/4] scsi: Clean up duplicated error in legacy if=scsi code

2015-02-21 Thread Peter Crosthwaite
On Fri, Feb 20, 2015 at 11:19 AM, Markus Armbruster wrote: > Commit a818a4b changed scsi_bus_legacy_handle_cmdline() to report > errors from scsi_bus_legacy_add_drive() with error_report() in > addition to returning them. That's inappropriate. > > Two kinds of callers: > > 1. realize methods (dev

[Qemu-devel] [PATCH 1/4] scsi: Clean up duplicated error in legacy if=scsi code

2015-02-20 Thread Markus Armbruster
Commit a818a4b changed scsi_bus_legacy_handle_cmdline() to report errors from scsi_bus_legacy_add_drive() with error_report() in addition to returning them. That's inappropriate. Two kinds of callers: 1. realize methods (devices "esp" and "virtio-scsi-device") The error object gets passed up