Re: [Qemu-devel] [PATCH 1/4] qom: split object_property_set_link()

2014-03-05 Thread Andreas Färber
Am 04.03.2014 22:45, schrieb Stefan Hajnoczi: > The path resolution logic in object_property_set_link() should be a > separate function. This makes the code easier to read and maintain. > > More importantly, the error behavior of object_property_set_link() is > dangerous. It sets the link proper

[Qemu-devel] [PATCH 1/4] qom: split object_property_set_link()

2014-03-04 Thread Stefan Hajnoczi
The path resolution logic in object_property_set_link() should be a separate function. This makes the code easier to read and maintain. More importantly, the error behavior of object_property_set_link() is dangerous. It sets the link property object to NULL if an error occurs. A setter function