Re: [Qemu-devel] [PATCH 1/4] qobject: Correct JSON lexer grammar comments

2016-06-21 Thread Eric Blake
On 06/17/2016 01:54 AM, Markus Armbruster wrote: >>> >>> I'll take this one through qapi-next. Thanks! >>> >> >> You may want to squash this in for shorter lines: >> >> >> diff --git a/qobject/json-lexer.c b/qobject/json-lexer.c >> index de16219..b030576 100644 >> --- a/qobject/json-lexer.c >> ++

Re: [Qemu-devel] [PATCH 1/4] qobject: Correct JSON lexer grammar comments

2016-06-17 Thread Markus Armbruster
Eric Blake writes: > On 06/16/2016 10:19 AM, Markus Armbruster wrote: >> Eric Blake writes: >> >>> Fix the regex comments describing what we parse as JSON. No change >>> to the lexer itself, just to the comments: >>> - The "" and '' string construction was missing alternation between >>> diffe

Re: [Qemu-devel] [PATCH 1/4] qobject: Correct JSON lexer grammar comments

2016-06-16 Thread Eric Blake
On 06/16/2016 10:19 AM, Markus Armbruster wrote: > Eric Blake writes: > >> Fix the regex comments describing what we parse as JSON. No change >> to the lexer itself, just to the comments: >> - The "" and '' string construction was missing alternation between >> different escape sequences >> -

Re: [Qemu-devel] [PATCH 1/4] qobject: Correct JSON lexer grammar comments

2016-06-16 Thread Markus Armbruster
Eric Blake writes: > Fix the regex comments describing what we parse as JSON. No change > to the lexer itself, just to the comments: > - The "" and '' string construction was missing alternation between > different escape sequences > - The construction for numbers forgot to handle optional leadi

[Qemu-devel] [PATCH 1/4] qobject: Correct JSON lexer grammar comments

2016-06-09 Thread Eric Blake
Fix the regex comments describing what we parse as JSON. No change to the lexer itself, just to the comments: - The "" and '' string construction was missing alternation between different escape sequences - The construction for numbers forgot to handle optional leading '-' - The construction for n