Re: [Qemu-devel] [PATCH 1/4] libvhost-user: add vmsg_set_reply_u64() helper

2019-06-21 Thread Marc-André Lureau
On Fri, Jun 21, 2019 at 11:40 AM Stefan Hajnoczi wrote: > > The VhostUserMsg request is reused as the reply by message processing > functions. This is risky since request fields may corrupt the reply if > the vhost-user message handler function forgets to re-initialize them. > > Changing this pra

[Qemu-devel] [PATCH 1/4] libvhost-user: add vmsg_set_reply_u64() helper

2019-06-21 Thread Stefan Hajnoczi
The VhostUserMsg request is reused as the reply by message processing functions. This is risky since request fields may corrupt the reply if the vhost-user message handler function forgets to re-initialize them. Changing this practice would be very invasive but we can introduce a helper function