Re: [Qemu-devel] [PATCH 1/4] hostmem-memfd: enable seals only if supported

2018-11-27 Thread Marc-André Lureau
On Tue, Nov 27, 2018 at 5:07 PM Ilya Maximets wrote: > > On 27.11.2018 15:56, Marc-André Lureau wrote: > > Hi > > > > On Tue, Nov 27, 2018 at 4:37 PM Ilya Maximets > > wrote: > >> > >> On 27.11.2018 15:29, Marc-André Lureau wrote: > >>> Hi > >>> > >>> On Tue, Nov 27, 2018 at 4:02 PM Ilya Maximet

Re: [Qemu-devel] [PATCH 1/4] hostmem-memfd: enable seals only if supported

2018-11-27 Thread Ilya Maximets
On 27.11.2018 15:56, Marc-André Lureau wrote: > Hi > > On Tue, Nov 27, 2018 at 4:37 PM Ilya Maximets wrote: >> >> On 27.11.2018 15:29, Marc-André Lureau wrote: >>> Hi >>> >>> On Tue, Nov 27, 2018 at 4:02 PM Ilya Maximets >>> wrote: On 27.11.2018 15:00, Marc-André Lureau wrote: > H

Re: [Qemu-devel] [PATCH 1/4] hostmem-memfd: enable seals only if supported

2018-11-27 Thread Marc-André Lureau
Hi On Tue, Nov 27, 2018 at 4:37 PM Ilya Maximets wrote: > > On 27.11.2018 15:29, Marc-André Lureau wrote: > > Hi > > > > On Tue, Nov 27, 2018 at 4:02 PM Ilya Maximets > > wrote: > >> > >> On 27.11.2018 15:00, Marc-André Lureau wrote: > >>> Hi > >>> On Tue, Nov 27, 2018 at 3:56 PM Ilya Maximets

Re: [Qemu-devel] [PATCH 1/4] hostmem-memfd: enable seals only if supported

2018-11-27 Thread Ilya Maximets
On 27.11.2018 15:29, Marc-André Lureau wrote: > Hi > > On Tue, Nov 27, 2018 at 4:02 PM Ilya Maximets wrote: >> >> On 27.11.2018 15:00, Marc-André Lureau wrote: >>> Hi >>> On Tue, Nov 27, 2018 at 3:56 PM Ilya Maximets >>> wrote: On 27.11.2018 14:49, Marc-André Lureau wrote: > Hi >>

Re: [Qemu-devel] [PATCH 1/4] hostmem-memfd: enable seals only if supported

2018-11-27 Thread Gerd Hoffmann
Hi, > > > which system supports memfd without sealing? > > > > RHEL 7.2. kernel version 3.10.0-327.el7.x86_64 > > Correct, it was backported without sealing for some reason. > > I would rather have an explicit seal=off argument on such system > (because sealing is expected to be available with

Re: [Qemu-devel] [PATCH 1/4] hostmem-memfd: enable seals only if supported

2018-11-27 Thread Marc-André Lureau
Hi On Tue, Nov 27, 2018 at 4:02 PM Ilya Maximets wrote: > > On 27.11.2018 15:00, Marc-André Lureau wrote: > > Hi > > On Tue, Nov 27, 2018 at 3:56 PM Ilya Maximets > > wrote: > >> > >> On 27.11.2018 14:49, Marc-André Lureau wrote: > >>> Hi > >>> On Tue, Nov 27, 2018 at 3:11 PM Ilya Maximets >

Re: [Qemu-devel] [PATCH 1/4] hostmem-memfd: enable seals only if supported

2018-11-27 Thread Ilya Maximets
On 27.11.2018 15:00, Marc-André Lureau wrote: > Hi > On Tue, Nov 27, 2018 at 3:56 PM Ilya Maximets wrote: >> >> On 27.11.2018 14:49, Marc-André Lureau wrote: >>> Hi >>> On Tue, Nov 27, 2018 at 3:11 PM Ilya Maximets >>> wrote: If seals are not supported, memfd_create() will fail. F

Re: [Qemu-devel] [PATCH 1/4] hostmem-memfd: enable seals only if supported

2018-11-27 Thread Marc-André Lureau
Hi On Tue, Nov 27, 2018 at 3:56 PM Ilya Maximets wrote: > > On 27.11.2018 14:49, Marc-André Lureau wrote: > > Hi > > On Tue, Nov 27, 2018 at 3:11 PM Ilya Maximets > > wrote: > >> > >> If seals are not supported, memfd_create() will fail. > >> Furthermore, there is no way to disable it in this ca

Re: [Qemu-devel] [PATCH 1/4] hostmem-memfd: enable seals only if supported

2018-11-27 Thread Ilya Maximets
On 27.11.2018 14:49, Marc-André Lureau wrote: > Hi > On Tue, Nov 27, 2018 at 3:11 PM Ilya Maximets wrote: >> >> If seals are not supported, memfd_create() will fail. >> Furthermore, there is no way to disable it in this case because >> '.seal' property is not registered. >> >> This issue leads to

Re: [Qemu-devel] [PATCH 1/4] hostmem-memfd: enable seals only if supported

2018-11-27 Thread Marc-André Lureau
Hi On Tue, Nov 27, 2018 at 3:11 PM Ilya Maximets wrote: > > If seals are not supported, memfd_create() will fail. > Furthermore, there is no way to disable it in this case because > '.seal' property is not registered. > > This issue leads to vhost-user-test failures on RHEL 7.2: > > qemu-system-

[Qemu-devel] [PATCH 1/4] hostmem-memfd: enable seals only if supported

2018-11-27 Thread Ilya Maximets
If seals are not supported, memfd_create() will fail. Furthermore, there is no way to disable it in this case because '.seal' property is not registered. This issue leads to vhost-user-test failures on RHEL 7.2: qemu-system-x86_64: -object memory-backend-memfd,id=mem,size=2M,: \