Re: [Qemu-devel] [PATCH 1/4] fifolock: create rfifolock_is_locked helper

2015-11-02 Thread Denis V. Lunev
On 11/02/2015 04:55 PM, Paolo Bonzini wrote: On 02/11/2015 14:39, Denis V. Lunev wrote: This is thread-safe: bool owner; qemu_mutex_lock(&r->lock); owner = r->nesting > 0 && qemu_thread_is_self(&r->owner_thread); qemu_mutex_unlock(&r->lock); return owner; yep, I know. But I do not want to

Re: [Qemu-devel] [PATCH 1/4] fifolock: create rfifolock_is_locked helper

2015-11-02 Thread Paolo Bonzini
On 02/11/2015 14:39, Denis V. Lunev wrote: >> This is thread-safe: >> >> bool owner; >> >> qemu_mutex_lock(&r->lock); >> owner = r->nesting > 0 && qemu_thread_is_self(&r->owner_thread); >> qemu_mutex_unlock(&r->lock); >> >> return owner; > yep, I know. > > But I do not want to take the lock for

Re: [Qemu-devel] [PATCH 1/4] fifolock: create rfifolock_is_locked helper

2015-11-02 Thread Denis V. Lunev
On 11/02/2015 04:12 PM, Stefan Hajnoczi wrote: On Sun, Nov 01, 2015 at 04:55:51PM +0300, Denis V. Lunev wrote: On 10/30/2015 06:41 PM, Stefan Hajnoczi wrote: On Wed, Oct 28, 2015 at 06:01:02PM +0300, Denis V. Lunev wrote: +int rfifolock_is_locked(RFifoLock *r); Please use bool instead of int

Re: [Qemu-devel] [PATCH 1/4] fifolock: create rfifolock_is_locked helper

2015-11-02 Thread Stefan Hajnoczi
On Sun, Nov 01, 2015 at 04:55:51PM +0300, Denis V. Lunev wrote: > On 10/30/2015 06:41 PM, Stefan Hajnoczi wrote: > >On Wed, Oct 28, 2015 at 06:01:02PM +0300, Denis V. Lunev wrote: > >>+int rfifolock_is_locked(RFifoLock *r); > >Please use bool instead of int. > > > >>diff --git a/util/rfifolock.c b

Re: [Qemu-devel] [PATCH 1/4] fifolock: create rfifolock_is_locked helper

2015-11-02 Thread Stefan Hajnoczi
On Fri, Oct 30, 2015 at 11:30:04PM +0300, Denis V. Lunev wrote: > On 10/30/2015 06:41 PM, Stefan Hajnoczi wrote: > >On Wed, Oct 28, 2015 at 06:01:02PM +0300, Denis V. Lunev wrote: > >>+int rfifolock_is_locked(RFifoLock *r); > >Please use bool instead of int. > > > >>diff --git a/util/rfifolock.c b

Re: [Qemu-devel] [PATCH 1/4] fifolock: create rfifolock_is_locked helper

2015-11-01 Thread Denis V. Lunev
On 10/30/2015 06:41 PM, Stefan Hajnoczi wrote: On Wed, Oct 28, 2015 at 06:01:02PM +0300, Denis V. Lunev wrote: +int rfifolock_is_locked(RFifoLock *r); Please use bool instead of int. diff --git a/util/rfifolock.c b/util/rfifolock.c index afbf748..8ac58cb 100644 --- a/util/rfifolock.c +++ b/u

Re: [Qemu-devel] [PATCH 1/4] fifolock: create rfifolock_is_locked helper

2015-10-30 Thread Denis V. Lunev
On 10/30/2015 06:41 PM, Stefan Hajnoczi wrote: On Wed, Oct 28, 2015 at 06:01:02PM +0300, Denis V. Lunev wrote: +int rfifolock_is_locked(RFifoLock *r); Please use bool instead of int. diff --git a/util/rfifolock.c b/util/rfifolock.c index afbf748..8ac58cb 100644 --- a/util/rfifolock.c +++ b/u

Re: [Qemu-devel] [PATCH 1/4] fifolock: create rfifolock_is_locked helper

2015-10-30 Thread Stefan Hajnoczi
On Wed, Oct 28, 2015 at 06:01:02PM +0300, Denis V. Lunev wrote: > +int rfifolock_is_locked(RFifoLock *r); Please use bool instead of int. > diff --git a/util/rfifolock.c b/util/rfifolock.c > index afbf748..8ac58cb 100644 > --- a/util/rfifolock.c > +++ b/util/rfifolock.c > @@ -48,7 +48,7 @@ void

[Qemu-devel] [PATCH 1/4] fifolock: create rfifolock_is_locked helper

2015-10-28 Thread Denis V. Lunev
This helper is necessary to ensure locking constraints. Signed-off-by: Denis V. Lunev CC: Stefan Hajnoczi CC: Paolo Bonzini --- include/qemu/rfifolock.h | 1 + util/rfifolock.c | 9 +++-- 2 files changed, 8 insertions(+), 2 deletions(-) diff --git a/include/qemu/rfifolock.h b/incl