Re: [Qemu-devel] [PATCH 1/4] Rename DriveInfo.onerror to on_write_error

2009-12-04 Thread Kevin Wolf
Am 03.12.2009 20:55, schrieb Anthony Liguori: > Gleb Natapov wrote: >> On Fri, Nov 27, 2009 at 01:25:36PM +0100, Kevin Wolf wrote: >> >>> Either rename variables and functions to refer to write errors (which is >>> what >>> they actually do) or introduce a parameter to distinguish reads and wri

Re: [Qemu-devel] [PATCH 1/4] Rename DriveInfo.onerror to on_write_error

2009-12-03 Thread Anthony Liguori
Gleb Natapov wrote: On Fri, Nov 27, 2009 at 01:25:36PM +0100, Kevin Wolf wrote: Either rename variables and functions to refer to write errors (which is what they actually do) or introduce a parameter to distinguish reads and writes. I prefer either to use two different functions or hi

Re: [Qemu-devel] [PATCH 1/4] Rename DriveInfo.onerror to on_write_error

2009-11-29 Thread Gleb Natapov
On Fri, Nov 27, 2009 at 01:25:36PM +0100, Kevin Wolf wrote: > Either rename variables and functions to refer to write errors (which is what > they actually do) or introduce a parameter to distinguish reads and writes. > I prefer either to use two different functions or hide 0/1 parameter behind a

[Qemu-devel] [PATCH 1/4] Rename DriveInfo.onerror to on_write_error

2009-11-27 Thread Kevin Wolf
Either rename variables and functions to refer to write errors (which is what they actually do) or introduce a parameter to distinguish reads and writes. Signed-off-by: Kevin Wolf --- hw/ide/core.c |2 +- hw/scsi-disk.c |3 ++- hw/virtio-blk.c |2 +- sysemu.h|6 --