Re: [Qemu-devel] [PATCH 1/3] virtio: Introduce VirtIODevice.broken

2014-04-29 Thread Paolo Bonzini
Il 28/04/2014 04:59, Michael S. Tsirkin ha scritto: All in all, it seems like a lot of work. But I think I see a nice elegant solution : stop the VM when some device detects an internal error and becomes broken. This should be a general event telling management that this happened - similar to pv

Re: [Qemu-devel] [PATCH 1/3] virtio: Introduce VirtIODevice.broken

2014-04-27 Thread Michael S. Tsirkin
On Mon, Apr 28, 2014 at 09:58:53AM +0800, Fam Zheng wrote: > On Sun, 04/27 11:59, Michael S. Tsirkin wrote: > > On Sun, Apr 27, 2014 at 09:34:06AM +0100, Peter Maydell wrote: > > > On 27 April 2014 09:29, Michael S. Tsirkin wrote: > > > > On Tue, Apr 22, 2014 at 04:55:15PM +0800, Fam Zheng wrote:

Re: [Qemu-devel] [PATCH 1/3] virtio: Introduce VirtIODevice.broken

2014-04-27 Thread Fam Zheng
On Sun, 04/27 11:59, Michael S. Tsirkin wrote: > On Sun, Apr 27, 2014 at 09:34:06AM +0100, Peter Maydell wrote: > > On 27 April 2014 09:29, Michael S. Tsirkin wrote: > > > On Tue, Apr 22, 2014 at 04:55:15PM +0800, Fam Zheng wrote: > > >> If guest driver behaves abnormally, emulation code could mar

Re: [Qemu-devel] [PATCH 1/3] virtio: Introduce VirtIODevice.broken

2014-04-27 Thread Michael S. Tsirkin
On Sun, Apr 27, 2014 at 09:34:06AM +0100, Peter Maydell wrote: > On 27 April 2014 09:29, Michael S. Tsirkin wrote: > > On Tue, Apr 22, 2014 at 04:55:15PM +0800, Fam Zheng wrote: > >> If guest driver behaves abnormally, emulation code could mark the device > >> as "broken". > >> > >> Once "broken"

Re: [Qemu-devel] [PATCH 1/3] virtio: Introduce VirtIODevice.broken

2014-04-27 Thread Peter Maydell
On 27 April 2014 09:29, Michael S. Tsirkin wrote: > On Tue, Apr 22, 2014 at 04:55:15PM +0800, Fam Zheng wrote: >> If guest driver behaves abnormally, emulation code could mark the device >> as "broken". >> >> Once "broken" is set, device emulation will typically wait for a reset >> command and ign

Re: [Qemu-devel] [PATCH 1/3] virtio: Introduce VirtIODevice.broken

2014-04-27 Thread Michael S. Tsirkin
On Tue, Apr 22, 2014 at 04:55:15PM +0800, Fam Zheng wrote: > If guest driver behaves abnormally, emulation code could mark the device > as "broken". > > Once "broken" is set, device emulation will typically wait for a reset > command and ignore any other operations, but it could also return error

Re: [Qemu-devel] [PATCH 1/3] virtio: Introduce VirtIODevice.broken

2014-04-24 Thread Fam Zheng
On Thu, 04/24 17:28, Michael S. Tsirkin wrote: > On Thu, Apr 24, 2014 at 11:19:14AM +0800, Fam Zheng wrote: > > On Wed, 04/23 10:17, Michael S. Tsirkin wrote: > > > On Tue, Apr 22, 2014 at 04:55:15PM +0800, Fam Zheng wrote: > > > > If guest driver behaves abnormally, emulation code could mark the d

Re: [Qemu-devel] [PATCH 1/3] virtio: Introduce VirtIODevice.broken

2014-04-24 Thread Michael S. Tsirkin
On Thu, Apr 24, 2014 at 11:19:14AM +0800, Fam Zheng wrote: > On Wed, 04/23 10:17, Michael S. Tsirkin wrote: > > On Tue, Apr 22, 2014 at 04:55:15PM +0800, Fam Zheng wrote: > > > If guest driver behaves abnormally, emulation code could mark the device > > > as "broken". > > > > > > Once "broken" is

Re: [Qemu-devel] [PATCH 1/3] virtio: Introduce VirtIODevice.broken

2014-04-23 Thread Michael S. Tsirkin
On Thu, Apr 24, 2014 at 11:19:14AM +0800, Fam Zheng wrote: > On Wed, 04/23 10:17, Michael S. Tsirkin wrote: > > On Tue, Apr 22, 2014 at 04:55:15PM +0800, Fam Zheng wrote: > > > If guest driver behaves abnormally, emulation code could mark the device > > > as "broken". > > > > > > Once "broken" is

Re: [Qemu-devel] [PATCH 1/3] virtio: Introduce VirtIODevice.broken

2014-04-23 Thread Fam Zheng
On Wed, 04/23 10:17, Michael S. Tsirkin wrote: > On Tue, Apr 22, 2014 at 04:55:15PM +0800, Fam Zheng wrote: > > If guest driver behaves abnormally, emulation code could mark the device > > as "broken". > > > > Once "broken" is set, device emulation will typically wait for a reset > > command and i

Re: [Qemu-devel] [PATCH 1/3] virtio: Introduce VirtIODevice.broken

2014-04-23 Thread Michael S. Tsirkin
On Tue, Apr 22, 2014 at 04:55:15PM +0800, Fam Zheng wrote: > If guest driver behaves abnormally, emulation code could mark the device > as "broken". > > Once "broken" is set, device emulation will typically wait for a reset > command and ignore any other operations, but it could also return error

Re: [Qemu-devel] [PATCH 1/3] virtio: Introduce VirtIODevice.broken

2014-04-22 Thread Greg Kurz
On Tue, 22 Apr 2014 12:16:07 +0200 Andreas Färber wrote: > Am 22.04.2014 12:12, schrieb Fam Zheng: > > On Tue, 04/22 17:58, Jason Wang wrote: > >> On 04/22/2014 04:55 PM, Fam Zheng wrote: > >>> diff --git a/hw/virtio/virtio.c b/hw/virtio/virtio.c > >>> index aeabf3a..222bb73 100644 > >>> --- a/hw/

Re: [Qemu-devel] [PATCH 1/3] virtio: Introduce VirtIODevice.broken

2014-04-22 Thread Fam Zheng
On Tue, 04/22 12:05, Andreas Färber wrote: > Am 22.04.2014 10:55, schrieb Fam Zheng: > > If guest driver behaves abnormally, emulation code could mark the device > > as "broken". > > > > Once "broken" is set, device emulation will typically wait for a reset > > command and ignore any other operati

Re: [Qemu-devel] [PATCH 1/3] virtio: Introduce VirtIODevice.broken

2014-04-22 Thread Andreas Färber
Am 22.04.2014 12:12, schrieb Fam Zheng: > On Tue, 04/22 17:58, Jason Wang wrote: >> On 04/22/2014 04:55 PM, Fam Zheng wrote: >>> diff --git a/hw/virtio/virtio.c b/hw/virtio/virtio.c >>> index aeabf3a..222bb73 100644 >>> --- a/hw/virtio/virtio.c >>> +++ b/hw/virtio/virtio.c [...] >>> @@ -995,6 +1006

Re: [Qemu-devel] [PATCH 1/3] virtio: Introduce VirtIODevice.broken

2014-04-22 Thread Fam Zheng
On Tue, 04/22 17:58, Jason Wang wrote: > On 04/22/2014 04:55 PM, Fam Zheng wrote: > > If guest driver behaves abnormally, emulation code could mark the device > > as "broken". > > > > Once "broken" is set, device emulation will typically wait for a reset > > command and ignore any other operations,

Re: [Qemu-devel] [PATCH 1/3] virtio: Introduce VirtIODevice.broken

2014-04-22 Thread Andreas Färber
Am 22.04.2014 10:55, schrieb Fam Zheng: > If guest driver behaves abnormally, emulation code could mark the device > as "broken". > > Once "broken" is set, device emulation will typically wait for a reset > command and ignore any other operations, but it could also return error > responds. In othe

Re: [Qemu-devel] [PATCH 1/3] virtio: Introduce VirtIODevice.broken

2014-04-22 Thread Jason Wang
On 04/22/2014 04:55 PM, Fam Zheng wrote: > If guest driver behaves abnormally, emulation code could mark the device > as "broken". > > Once "broken" is set, device emulation will typically wait for a reset > command and ignore any other operations, but it could also return error > responds. In othe

[Qemu-devel] [PATCH 1/3] virtio: Introduce VirtIODevice.broken

2014-04-22 Thread Fam Zheng
If guest driver behaves abnormally, emulation code could mark the device as "broken". Once "broken" is set, device emulation will typically wait for a reset command and ignore any other operations, but it could also return error responds. In other words, whether and how does guest know about this