Re: [Qemu-devel] [PATCH 1/3] target-arm: convert void helpers

2012-09-08 Thread Blue Swirl
On Thu, Sep 6, 2012 at 7:00 PM, Peter Maydell wrote: > On 4 September 2012 21:48, Peter Maydell wrote: >> On 4 September 2012 21:37, Blue Swirl wrote: >>> Add an explicit CPUState parameter instead of relying on AREG0. >>> >>> For easier review, convert only op helpers which don't return any val

Re: [Qemu-devel] [PATCH 1/3] target-arm: convert void helpers

2012-09-06 Thread Peter Maydell
On 4 September 2012 21:48, Peter Maydell wrote: > On 4 September 2012 21:37, Blue Swirl wrote: >> Add an explicit CPUState parameter instead of relying on AREG0. >> >> For easier review, convert only op helpers which don't return any value. >> >> Signed-off-by: Blue Swirl > > Reviewed-by: Peter

Re: [Qemu-devel] [PATCH 1/3] target-arm: convert void helpers

2012-09-04 Thread Peter Maydell
On 4 September 2012 21:37, Blue Swirl wrote: > Add an explicit CPUState parameter instead of relying on AREG0. > > For easier review, convert only op helpers which don't return any value. > > Signed-off-by: Blue Swirl Reviewed-by: Peter Maydell Thanks for splitting these up, it helped a lot.

[Qemu-devel] [PATCH 1/3] target-arm: convert void helpers

2012-09-04 Thread Blue Swirl
Add an explicit CPUState parameter instead of relying on AREG0. For easier review, convert only op helpers which don't return any value. Signed-off-by: Blue Swirl --- target-arm/helper.h|8 target-arm/op_helper.c | 20 ++-- target-arm/translate.c |8 --