Re: [Qemu-devel] [PATCH 1/3] target-arm: Setup smpboot code in all setups

2011-02-15 Thread Peter Maydell
On 15 February 2011 15:02, Vincent Palatin wrote: > This assumes that all the ARM SMP platforms are booting their > secondary CPU the same way as the emulated Realview. > For example, I'm currently writing a Tegra2 (dual A9) SoC emulation > and the second CPU is halted when the platform starts and

Re: [Qemu-devel] [PATCH 1/3] target-arm: Setup smpboot code in all setups

2011-02-15 Thread Adam Lackorzynski
Hi, On Tue Feb 15, 2011 at 10:02:05 -0500, Vincent Palatin wrote: > >> Moving in the right direction, but it would be cleaner if the secondary > >> CPU reset was handled inside arm_boot.c, I think (there is a TODO > >> in that file to that effect). Then we could get rid of the cpu reset > >> hook

Re: [Qemu-devel] [PATCH 1/3] target-arm: Setup smpboot code in all setups

2011-02-15 Thread Vincent Palatin
Hi Adam, >> Moving in the right direction, but it would be cleaner if the secondary >> CPU reset was handled inside arm_boot.c, I think (there is a TODO >> in that file to that effect). Then we could get rid of the cpu reset >> hook from realview.c. > > Like the following? This assumes that all t

Re: [Qemu-devel] [PATCH 1/3] target-arm: Setup smpboot code in all setups

2011-02-15 Thread Adam Lackorzynski
On Tue Feb 15, 2011 at 13:37:44 +, Peter Maydell wrote: > On 15 February 2011 13:12, Adam Lackorzynski > wrote: > > > > On Tue Feb 15, 2011 at 13:01:08 +, Peter Maydell wrote: > >> On 15 February 2011 10:48, Adam Lackorzynski > >> wrote: > >> > Make smpboot available not only for Linux

Re: [Qemu-devel] [PATCH 1/3] target-arm: Setup smpboot code in all setups

2011-02-15 Thread Peter Maydell
On 15 February 2011 13:12, Adam Lackorzynski wrote: > > On Tue Feb 15, 2011 at 13:01:08 +, Peter Maydell wrote: >> On 15 February 2011 10:48, Adam Lackorzynski >> wrote: >> > Make smpboot available not only for Linux but for all setups. >> >> I'm not convinced about this. I think if you're p

Re: [Qemu-devel] [PATCH 1/3] target-arm: Setup smpboot code in all setups

2011-02-15 Thread Adam Lackorzynski
On Tue Feb 15, 2011 at 13:01:08 +, Peter Maydell wrote: > On 15 February 2011 10:48, Adam Lackorzynski > wrote: > > Make smpboot available not only for Linux but for all setups. > > I'm not convinced about this. I think if you're providing a raw > image for an SMP system (rather than a Linu

Re: [Qemu-devel] [PATCH 1/3] target-arm: Setup smpboot code in all setups

2011-02-15 Thread Peter Maydell
On 15 February 2011 10:48, Adam Lackorzynski wrote: > Make smpboot available not only for Linux but for all setups. I'm not convinced about this. I think if you're providing a raw image for an SMP system (rather than a Linux kernel) then it's your job to provide an image which handles the bootup

[Qemu-devel] [PATCH 1/3] target-arm: Setup smpboot code in all setups

2011-02-15 Thread Adam Lackorzynski
Make smpboot available not only for Linux but for all setups. Signed-off-by: Adam Lackorzynski --- hw/arm_boot.c | 17 + 1 files changed, 9 insertions(+), 8 deletions(-) diff --git a/hw/arm_boot.c b/hw/arm_boot.c index 620550b..a68b396 100644 --- a/hw/arm_boot.c +++ b/hw/arm_b