Re: [Qemu-devel] [PATCH 1/3] spapr: drop duplicate variable in spapr_core_plug()

2018-01-17 Thread David Gibson
On Wed, Jan 17, 2018 at 10:20:27AM +0100, Greg Kurz wrote: > A variable is already defined at the begining of the function to > hold a pointer to the CPU core object: > > sPAPRCPUCore *core = SPAPR_CPU_CORE(OBJECT(dev)); > > No need to define it again in the pre-2.10 compatibility code snippl

[Qemu-devel] [PATCH 1/3] spapr: drop duplicate variable in spapr_core_plug()

2018-01-17 Thread Greg Kurz
A variable is already defined at the begining of the function to hold a pointer to the CPU core object: sPAPRCPUCore *core = SPAPR_CPU_CORE(OBJECT(dev)); No need to define it again in the pre-2.10 compatibility code snipplet. Signed-off-by: Greg Kurz --- hw/ppc/spapr.c |4 +--- 1 file