Re: [Qemu-devel] [PATCH 1/3] qmp/hmp: Add QMP getfd command that returns fd

2012-06-08 Thread Corey Bryant
On 06/08/2012 06:46 AM, Daniel P. Berrange wrote: On Wed, Jun 06, 2012 at 10:04:23AM -0400, Corey Bryant wrote: On 06/05/2012 02:30 PM, Luiz Capitulino wrote: On Mon, 4 Jun 2012 09:10:08 -0400 Corey Bryant wrote: This patch adds QMP support for the getfd command using the QAPI framewor

Re: [Qemu-devel] [PATCH 1/3] qmp/hmp: Add QMP getfd command that returns fd

2012-06-08 Thread Daniel P. Berrange
On Wed, Jun 06, 2012 at 10:04:23AM -0400, Corey Bryant wrote: > > > On 06/05/2012 02:30 PM, Luiz Capitulino wrote: > >On Mon, 4 Jun 2012 09:10:08 -0400 > >Corey Bryant wrote: > > > >>This patch adds QMP support for the getfd command using the QAPI framework. > >>Like the HMP getfd command, it i

Re: [Qemu-devel] [PATCH 1/3] qmp/hmp: Add QMP getfd command that returns fd

2012-06-06 Thread Corey Bryant
On 06/06/2012 01:50 PM, Luiz Capitulino wrote: On Wed, 06 Jun 2012 10:04:23 -0400 Corey Bryant wrote: Today, we return a dict on success: { "return": {} } But this patch changes it to: { "return": 42 } There are two ways to do this without breaking compatibility: 1. Add a new c

Re: [Qemu-devel] [PATCH 1/3] qmp/hmp: Add QMP getfd command that returns fd

2012-06-06 Thread Luiz Capitulino
On Wed, 06 Jun 2012 10:04:23 -0400 Corey Bryant wrote: > > Today, we return a dict on success: > > > > { "return": {} } > > > > But this patch changes it to: > > > > { "return": 42 } > > > > There are two ways to do this without breaking compatibility: > > > > 1. Add a new command (say get-

Re: [Qemu-devel] [PATCH 1/3] qmp/hmp: Add QMP getfd command that returns fd

2012-06-06 Thread Corey Bryant
On 06/05/2012 02:30 PM, Luiz Capitulino wrote: On Mon, 4 Jun 2012 09:10:08 -0400 Corey Bryant wrote: This patch adds QMP support for the getfd command using the QAPI framework. Like the HMP getfd command, it is used to pass a file descriptor via SCM_RIGHTS. However, the QMP getfd command a

Re: [Qemu-devel] [PATCH 1/3] qmp/hmp: Add QMP getfd command that returns fd

2012-06-05 Thread Luiz Capitulino
On Mon, 4 Jun 2012 09:10:08 -0400 Corey Bryant wrote: > This patch adds QMP support for the getfd command using the QAPI framework. > Like the HMP getfd command, it is used to pass a file descriptor via > SCM_RIGHTS. However, the QMP getfd command also returns the received file > descriptor, wh

Re: [Qemu-devel] [PATCH 1/3] qmp/hmp: Add QMP getfd command that returns fd

2012-06-04 Thread Corey Bryant
On 06/04/2012 10:45 AM, Kevin Wolf wrote: Am 04.06.2012 15:10, schrieb Corey Bryant: This patch adds QMP support for the getfd command using the QAPI framework. Like the HMP getfd command, it is used to pass a file descriptor via SCM_RIGHTS. However, the QMP getfd command also returns the rec

Re: [Qemu-devel] [PATCH 1/3] qmp/hmp: Add QMP getfd command that returns fd

2012-06-04 Thread Kevin Wolf
Am 04.06.2012 15:10, schrieb Corey Bryant: > This patch adds QMP support for the getfd command using the QAPI framework. > Like the HMP getfd command, it is used to pass a file descriptor via > SCM_RIGHTS. However, the QMP getfd command also returns the received file > descriptor, which is a diffe

[Qemu-devel] [PATCH 1/3] qmp/hmp: Add QMP getfd command that returns fd

2012-06-04 Thread Corey Bryant
This patch adds QMP support for the getfd command using the QAPI framework. Like the HMP getfd command, it is used to pass a file descriptor via SCM_RIGHTS. However, the QMP getfd command also returns the received file descriptor, which is a difference in behavior from the HMP getfd command, which