Re: [Qemu-devel] [PATCH 1/3] qga: add support to get host time

2013-01-14 Thread Eric Blake
On 01/13/2013 08:17 PM, Lei Li wrote: > On 01/11/2013 11:37 PM, Eric Blake wrote: >> On 01/11/2013 12:18 AM, Lei Li wrote: >>> For this version, it's a one-hour offset represented as:±[hh]. >>> Negative values are west, andpositive values are east of UTC. >> Won't work. There are timezones with a

Re: [Qemu-devel] [PATCH 1/3] qga: add support to get host time

2013-01-13 Thread Lei Li
On 01/11/2013 11:37 PM, Eric Blake wrote: On 01/11/2013 12:18 AM, Lei Li wrote: For this version, it's a one-hour offset represented as:±[hh]. Negative values are west, andpositive values are east of UTC. Won't work. There are timezones with a half-hour offset. You need to express offset at l

Re: [Qemu-devel] [PATCH 1/3] qga: add support to get host time

2013-01-11 Thread Eric Blake
On 01/11/2013 12:18 AM, Lei Li wrote: > > For this version, it's a one-hour offset represented as:±[hh]. > Negative values are west, andpositive values are east of UTC. Won't work. There are timezones with a half-hour offset. You need to express offset at least in terms of minutes, not just hou

Re: [Qemu-devel] [PATCH 1/3] qga: add support to get host time

2013-01-11 Thread Luiz Capitulino
On Fri, 11 Jan 2013 15:19:35 +0800 Lei Li wrote: > >> ## > >> +# @HostTimeInfo > > I'm a bit confused, why do you call it HostTimeInfo if this runs > > in the guest? > > I call it HostTimeInfo because it contains the host time information. qemu-ga runs in the guest, so it's actually the guest

Re: [Qemu-devel] [PATCH 1/3] qga: add support to get host time

2013-01-10 Thread Lei Li
On 01/09/2013 11:36 PM, mdroth wrote: On Sun, Jan 06, 2013 at 06:06:58PM +0800, Lei Li wrote: Signed-off-by: Lei Li --- qga/commands-posix.c | 18 ++ qga/qapi-schema.json | 17 + 2 files changed, 35 insertions(+), 0 deletions(-) diff --git a/qga/commands

Re: [Qemu-devel] [PATCH 1/3] qga: add support to get host time

2013-01-10 Thread Lei Li
On 01/09/2013 09:32 PM, Luiz Capitulino wrote: On Sun, 6 Jan 2013 18:06:58 +0800 Lei Li wrote: Signed-off-by: Lei Li --- qga/commands-posix.c | 18 ++ qga/qapi-schema.json | 17 + 2 files changed, 35 insertions(+), 0 deletions(-) diff --git a/qga/comm

Re: [Qemu-devel] [PATCH 1/3] qga: add support to get host time

2013-01-10 Thread Lei Li
On 01/08/2013 05:52 AM, Eric Blake wrote: On 01/06/2013 03:06 AM, Lei Li wrote: Signed-off-by: Lei Li --- qga/commands-posix.c | 18 ++ qga/qapi-schema.json | 17 + 2 files changed, 35 insertions(+), 0 deletions(-) diff --git a/qga/commands-posix.c b/qga

Re: [Qemu-devel] [PATCH 1/3] qga: add support to get host time

2013-01-09 Thread mdroth
On Sun, Jan 06, 2013 at 06:06:58PM +0800, Lei Li wrote: > Signed-off-by: Lei Li > --- > qga/commands-posix.c | 18 ++ > qga/qapi-schema.json | 17 + > 2 files changed, 35 insertions(+), 0 deletions(-) > > diff --git a/qga/commands-posix.c b/qga/commands-posix.

Re: [Qemu-devel] [PATCH 1/3] qga: add support to get host time

2013-01-09 Thread Luiz Capitulino
On Sun, 6 Jan 2013 18:06:58 +0800 Lei Li wrote: > Signed-off-by: Lei Li > --- > qga/commands-posix.c | 18 ++ > qga/qapi-schema.json | 17 + > 2 files changed, 35 insertions(+), 0 deletions(-) > > diff --git a/qga/commands-posix.c b/qga/commands-posix.c > i

Re: [Qemu-devel] [PATCH 1/3] qga: add support to get host time

2013-01-07 Thread Eric Blake
On 01/06/2013 03:06 AM, Lei Li wrote: > Signed-off-by: Lei Li > --- > qga/commands-posix.c | 18 ++ > qga/qapi-schema.json | 17 + > 2 files changed, 35 insertions(+), 0 deletions(-) > > diff --git a/qga/commands-posix.c b/qga/commands-posix.c > index a657201.

[Qemu-devel] [PATCH 1/3] qga: add support to get host time

2013-01-06 Thread Lei Li
Signed-off-by: Lei Li --- qga/commands-posix.c | 18 ++ qga/qapi-schema.json | 17 + 2 files changed, 35 insertions(+), 0 deletions(-) diff --git a/qga/commands-posix.c b/qga/commands-posix.c index a657201..26b0fa0 100644 --- a/qga/commands-posix.c +++ b/qga/c