Re: [Qemu-devel] [PATCH 1/3] qemu: add capability for vhost-net busy polling

2017-06-26 Thread Eric Blake
On 06/26/2017 09:24 PM, Eduardo Habkost wrote: >> I've posted patches in the past (qemu 2.6 timeframe, if I recall) that >> changed netdev_add into a fully-advertised interface, but we didn't take >> it then because we weren't sure how to handle the fact that netdev_add >> can currently accept both

Re: [Qemu-devel] [PATCH 1/3] qemu: add capability for vhost-net busy polling

2017-06-26 Thread Eduardo Habkost
On Mon, Jun 26, 2017 at 07:23:50AM -0600, Eric Blake wrote: > On 06/17/2017 09:15 PM, Eduardo Habkost wrote: > > (CCing qemu-devel and the QAPI maintainers. I have a question > > about introspection below.) > > > > > > > Fortunately, netdev options are modelled in the QAPI schema as > > union N

Re: [Qemu-devel] [PATCH 1/3] qemu: add capability for vhost-net busy polling

2017-06-26 Thread Eric Blake
On 06/17/2017 09:15 PM, Eduardo Habkost wrote: > (CCing qemu-devel and the QAPI maintainers. I have a question > about introspection below.) > > > Fortunately, netdev options are modelled in the QAPI schema as > union Netdev. However, 'query-qmp-schema' doesn't seem to > include union Netdev b

Re: [Qemu-devel] [PATCH 1/3] qemu: add capability for vhost-net busy polling

2017-06-17 Thread Eduardo Habkost
(CCing qemu-devel and the QAPI maintainers. I have a question about introspection below.) On Sat, Jun 17, 2017 at 11:48:10AM -0400, Laine Stump wrote: [...] > > +/* Support for busy polling on vhost-net devices ("-netdev > > + * tap,...,poll-us=n") */ > > +if (qemuCaps->version >= 200