ov; Andreas Färber
> Subject: Re: [Qemu-devel] [PATCH 1/3] qdev: add missing error check
>
> Il 19/08/2014 15:50, Peter Crosthwaite ha scritto:
> > So I'm curious to know if and how this manifested for you as a bug?
> > Can you reproduce this as a bug somehow even as a memory l
> > If local_err is not null, the next code logic is useless.
> >
> > Signed-off-by: Gonglei
> > ---
> > hw/core/qdev.c | 5 +
> > 1 file changed, 5 insertions(+)
> >
> > diff --git a/hw/core/qdev.c b/hw/core/qdev.c
> > index da1ba48..3e7085e 100644
> > --- a/hw/core/qdev.c
> > +++ b/hw/core/
Il 19/08/2014 15:50, Peter Crosthwaite ha scritto:
> So I'm curious to know if and how this manifested for you as a bug?
> Can you reproduce this as a bug somehow even as a memory leak? as the
> only way I can see local_err getting populated is a fail of:
>
> object_property_add_child(
On Tue, Aug 19, 2014 at 7:41 PM, wrote:
> From: Gonglei
>
> If local_err is not null, the next code logic is useless.
>
> Signed-off-by: Gonglei
> ---
> hw/core/qdev.c | 5 +
> 1 file changed, 5 insertions(+)
>
> diff --git a/hw/core/qdev.c b/hw/core/qdev.c
> index da1ba48..3e7085e 100644
From: Gonglei
If local_err is not null, the next code logic is useless.
Signed-off-by: Gonglei
---
hw/core/qdev.c | 5 +
1 file changed, 5 insertions(+)
diff --git a/hw/core/qdev.c b/hw/core/qdev.c
index da1ba48..3e7085e 100644
--- a/hw/core/qdev.c
+++ b/hw/core/qdev.c
@@ -830,6 +830,11 @