Re: [Qemu-devel] [PATCH 1/3] qapi: Pass '-u' when doing non-silent diff

2018-02-12 Thread Eric Blake
On 02/11/2018 06:04 AM, Markus Armbruster wrote: Eric Blake writes: Ed-script diffs are awful compared to context diffs. Fix another 'diff -q' while in the area (if the files are different, being noisy makes it easier to diagnose why). Fixes: 46ec4fce Signed-off-by: Eric Blake --- tests/M

Re: [Qemu-devel] [PATCH 1/3] qapi: Pass '-u' when doing non-silent diff

2018-02-11 Thread Markus Armbruster
Eric Blake writes: > Ed-script diffs are awful compared to context diffs. Fix another > 'diff -q' while in the area (if the files are different, being > noisy makes it easier to diagnose why). > > Fixes: 46ec4fce > Signed-off-by: Eric Blake > --- > tests/Makefile.include | 8 > 1 file

Re: [Qemu-devel] [PATCH 1/3] qapi: Pass '-u' when doing non-silent diff

2018-02-10 Thread Philippe Mathieu-Daudé
On Sat, Feb 10, 2018 at 9:40 PM, Eric Blake wrote: > Ed-script diffs are awful compared to context diffs. Fix another > 'diff -q' while in the area (if the files are different, being > noisy makes it easier to diagnose why). > > Fixes: 46ec4fce > Signed-off-by: Eric Blake Reviewed-by: Philippe

[Qemu-devel] [PATCH 1/3] qapi: Pass '-u' when doing non-silent diff

2018-02-10 Thread Eric Blake
Ed-script diffs are awful compared to context diffs. Fix another 'diff -q' while in the area (if the files are different, being noisy makes it easier to diagnose why). Fixes: 46ec4fce Signed-off-by: Eric Blake --- tests/Makefile.include | 8 1 file changed, 4 insertions(+), 4 deletions