Re: [Qemu-devel] [PATCH 1/3] qapi: Allow QMP/QAPI commands to have array inputs

2012-02-22 Thread Luiz Capitulino
On Wed, 22 Feb 2012 14:31:17 -0600 Anthony Liguori wrote: > On 02/22/2012 02:25 PM, Luiz Capitulino wrote: > > On Wed, 22 Feb 2012 11:35:26 -0600 > > Anthony Liguori wrote: > > > >> On 02/22/2012 10:12 AM, Jeff Cody wrote: > >>> On 02/22/2012 09:53 AM, Anthony Liguori wrote: > On 02/20/2012

Re: [Qemu-devel] [PATCH 1/3] qapi: Allow QMP/QAPI commands to have array inputs

2012-02-22 Thread Anthony Liguori
On 02/22/2012 02:25 PM, Luiz Capitulino wrote: On Wed, 22 Feb 2012 11:35:26 -0600 Anthony Liguori wrote: On 02/22/2012 10:12 AM, Jeff Cody wrote: On 02/22/2012 09:53 AM, Anthony Liguori wrote: On 02/20/2012 11:31 AM, Jeff Cody wrote: The QAPI scripts allow for generating commands that recei

Re: [Qemu-devel] [PATCH 1/3] qapi: Allow QMP/QAPI commands to have array inputs

2012-02-22 Thread Luiz Capitulino
On Wed, 22 Feb 2012 11:35:26 -0600 Anthony Liguori wrote: > On 02/22/2012 10:12 AM, Jeff Cody wrote: > > On 02/22/2012 09:53 AM, Anthony Liguori wrote: > >> On 02/20/2012 11:31 AM, Jeff Cody wrote: > >>> The QAPI scripts allow for generating commands that receive parameter > >>> input consisting

Re: [Qemu-devel] [PATCH 1/3] qapi: Allow QMP/QAPI commands to have array inputs

2012-02-22 Thread Jeff Cody
On 02/22/2012 12:56 PM, Anthony Liguori wrote: On 02/22/2012 11:47 AM, Eric Blake wrote: On 02/22/2012 10:35 AM, Anthony Liguori wrote: [1] JSON schema definition: { 'type': 'SnapshotDev', 'data': {'device': 'str', 'snapshot-file': 'str', '*format': 'str' } } { 'command': 'blockdev-group-sna

Re: [Qemu-devel] [PATCH 1/3] qapi: Allow QMP/QAPI commands to have array inputs

2012-02-22 Thread Jeff Cody
On 02/22/2012 12:35 PM, Anthony Liguori wrote: On 02/22/2012 10:12 AM, Jeff Cody wrote: On 02/22/2012 09:53 AM, Anthony Liguori wrote: On 02/20/2012 11:31 AM, Jeff Cody wrote: The QAPI scripts allow for generating commands that receive parameter input consisting of a list of custom structs, bu

Re: [Qemu-devel] [PATCH 1/3] qapi: Allow QMP/QAPI commands to have array inputs

2012-02-22 Thread Anthony Liguori
On 02/22/2012 11:47 AM, Eric Blake wrote: On 02/22/2012 10:35 AM, Anthony Liguori wrote: [1] JSON schema definition: { 'type': 'SnapshotDev', 'data': {'device': 'str', 'snapshot-file': 'str', '*format': 'str' } } { 'command': 'blockdev-group-snapshot-sync', 'data': { 'dev': [ 'SnapshotDev' ]

Re: [Qemu-devel] [PATCH 1/3] qapi: Allow QMP/QAPI commands to have array inputs

2012-02-22 Thread Eric Blake
On 02/22/2012 10:35 AM, Anthony Liguori wrote: >> [1] JSON schema definition: >> >> { 'type': 'SnapshotDev', >> 'data': {'device': 'str', 'snapshot-file': 'str', '*format': 'str' } } >> >> { 'command': 'blockdev-group-snapshot-sync', >> 'data': { 'dev': [ 'SnapshotDev' ] } } > > > This will end

Re: [Qemu-devel] [PATCH 1/3] qapi: Allow QMP/QAPI commands to have array inputs

2012-02-22 Thread Anthony Liguori
On 02/22/2012 10:12 AM, Jeff Cody wrote: On 02/22/2012 09:53 AM, Anthony Liguori wrote: On 02/20/2012 11:31 AM, Jeff Cody wrote: The QAPI scripts allow for generating commands that receive parameter input consisting of a list of custom structs, but the QMP input paramter checking did not suppor

Re: [Qemu-devel] [PATCH 1/3] qapi: Allow QMP/QAPI commands to have array inputs

2012-02-22 Thread Jeff Cody
On 02/22/2012 09:53 AM, Anthony Liguori wrote: On 02/20/2012 11:31 AM, Jeff Cody wrote: The QAPI scripts allow for generating commands that receive parameter input consisting of a list of custom structs, but the QMP input paramter checking did not support receiving a qlist as opposed to a qdict

Re: [Qemu-devel] [PATCH 1/3] qapi: Allow QMP/QAPI commands to have array inputs

2012-02-22 Thread Anthony Liguori
On 02/20/2012 11:31 AM, Jeff Cody wrote: The QAPI scripts allow for generating commands that receive parameter input consisting of a list of custom structs, but the QMP input paramter checking did not support receiving a qlist as opposed to a qdict for input. What are you trying to send on the

[Qemu-devel] [PATCH 1/3] qapi: Allow QMP/QAPI commands to have array inputs

2012-02-20 Thread Jeff Cody
The QAPI scripts allow for generating commands that receive parameter input consisting of a list of custom structs, but the QMP input paramter checking did not support receiving a qlist as opposed to a qdict for input. This patch allows for array input parameters, although no argument validation i