Re: [Qemu-devel] [PATCH 1/3] machine: remove qemu_machine_opts global list

2014-12-15 Thread Paolo Bonzini
On 15/12/2014 16:13, Alexander Graf wrote: > MACHINE_OPT(kvm_shadow_mem, "kvm-shadow-mem", "Use KVM in-kernel > irqchip", _bool, NULL); > > Not sure it's a great improvement though. I certainly wouldn't mind to > leave it as this patch does it. I agree. If we want to "hint" that every property

Re: [Qemu-devel] [PATCH 1/3] machine: remove qemu_machine_opts global list

2014-12-15 Thread Alexander Graf
On 11.12.14 06:05, Marcel Apfelbaum wrote: > On Wed, 2014-12-10 at 16:59 -0600, Greg Bellows wrote: >> >> >> On 10 December 2014 at 07:19, Marcel Apfelbaum >> wrote: >> QEMU has support for options per machine, keeping >> a global list of options is no longer necessary. >>

Re: [Qemu-devel] [PATCH 1/3] machine: remove qemu_machine_opts global list

2014-12-11 Thread Greg Bellows
On 10 December 2014 at 23:05, Marcel Apfelbaum wrote: > On Wed, 2014-12-10 at 16:59 -0600, Greg Bellows wrote: > > > > > > On 10 December 2014 at 07:19, Marcel Apfelbaum > > wrote: > > QEMU has support for options per machine, keeping > > a global list of options is no longer nec

Re: [Qemu-devel] [PATCH 1/3] machine: remove qemu_machine_opts global list

2014-12-10 Thread Marcel Apfelbaum
On Wed, 2014-12-10 at 16:59 -0600, Greg Bellows wrote: > > > On 10 December 2014 at 07:19, Marcel Apfelbaum > wrote: > QEMU has support for options per machine, keeping > a global list of options is no longer necessary. > > Signed-off-by: Marcel Apfelbaum >

Re: [Qemu-devel] [PATCH 1/3] machine: remove qemu_machine_opts global list

2014-12-10 Thread Greg Bellows
On 10 December 2014 at 07:19, Marcel Apfelbaum wrote: > QEMU has support for options per machine, keeping > a global list of options is no longer necessary. > > Signed-off-by: Marcel Apfelbaum > --- > hw/core/machine.c | 45 + > hw/i386/pc.c | 7 + > hw/ppc

[Qemu-devel] [PATCH 1/3] machine: remove qemu_machine_opts global list

2014-12-10 Thread Marcel Apfelbaum
QEMU has support for options per machine, keeping a global list of options is no longer necessary. Signed-off-by: Marcel Apfelbaum --- hw/core/machine.c | 45 + hw/i386/pc.c | 7 + hw/ppc/spapr.c| 3 ++ vl.c | 84 ---