Re: [Qemu-devel] [PATCH 1/3] ich9: add TCO interface emulation

2015-05-27 Thread Paulo Alcantara
On Wed, 27 May 2015 13:58:57 +0200 Paolo Bonzini wrote: > the main issue here is lack of migration support. You need to add a > new subsection to vmstate_ich9_pm that is migrated if the registers > are different from the default values. Hrm - OK. I didn't even take that into account. I'll do it

Re: [Qemu-devel] [PATCH 1/3] ich9: add TCO interface emulation

2015-05-27 Thread Paolo Bonzini
On 27/05/2015 02:29, Paulo Alcantara wrote: > This interface provides some registers within a 32-byte range and can be > acessed through PCI-to-LPC bridge interface (PMBASE + 0x60). > > It's commonly used as a watchdog timer to detect system lockups through > SMIs that are generated -- if TCO_EN

[Qemu-devel] [PATCH 1/3] ich9: add TCO interface emulation

2015-05-26 Thread Paulo Alcantara
This interface provides some registers within a 32-byte range and can be acessed through PCI-to-LPC bridge interface (PMBASE + 0x60). It's commonly used as a watchdog timer to detect system lockups through SMIs that are generated -- if TCO_EN bit is set -- on every timeout. If NO_REBOOT bit is not