Re: [Qemu-devel] [PATCH 1/3] hw/i386/pc.c: remove unused function pc_acpi_init()

2019-01-28 Thread Wei Yang
On Mon, Jan 28, 2019 at 02:32:30PM +0100, Igor Mammedov wrote: >On Fri, 25 Jan 2019 14:01:55 +0800 >Wei Yang wrote: > >> Function pc_acpi_init() is now used in no place. >s/is now used in no place./in not used anymore,/ > >fixup the same phrase in other patches. > >otherwise series looks good, so

Re: [Qemu-devel] [PATCH 1/3] hw/i386/pc.c: remove unused function pc_acpi_init()

2019-01-28 Thread Igor Mammedov
On Fri, 25 Jan 2019 14:01:55 +0800 Wei Yang wrote: > Function pc_acpi_init() is now used in no place. s/is now used in no place./in not used anymore,/ fixup the same phrase in other patches. otherwise series looks good, so fix commit messages and resubmit series. Also when sending multi-patch

[Qemu-devel] [PATCH 1/3] hw/i386/pc.c: remove unused function pc_acpi_init()

2019-01-24 Thread Wei Yang
Function pc_acpi_init() is now used in no place. Remove the definition and declaration. Signed-off-by: Wei Yang --- hw/i386/pc.c | 27 --- include/hw/i386/pc.h | 1 - 2 files changed, 28 deletions(-) diff --git a/hw/i386/pc.c b/hw/i386/pc.c index 5317e08f60..73