Re: [Qemu-devel] [PATCH 1/3] hw/arm/exynos: Convert fprintf to error_report()

2017-03-06 Thread Peter Maydell
On 6 March 2017 at 17:07, Krzysztof Kozlowski wrote: > On Mon, Mar 06, 2017 at 10:55:12AM -0600, Eric Blake wrote: >> I don't see a 0/3 cover letter. When sending multiple patches, it's >> always best to package them in-reply-to the cover letter ('git config >> format.coverLetter auto' makes it ea

Re: [Qemu-devel] [PATCH 1/3] hw/arm/exynos: Convert fprintf to error_report()

2017-03-06 Thread Krzysztof Kozlowski
On Mon, Mar 06, 2017 at 10:55:12AM -0600, Eric Blake wrote: > On 03/05/2017 03:48 PM, Krzysztof Kozlowski wrote: > > error_report() is preferred over fprintf() for logging errors. Also > > remove square brackets [] and additional new line characters in printed > > messages. > > > > Signed-off-by:

Re: [Qemu-devel] [PATCH 1/3] hw/arm/exynos: Convert fprintf to error_report()

2017-03-06 Thread Eric Blake
On 03/05/2017 03:48 PM, Krzysztof Kozlowski wrote: > error_report() is preferred over fprintf() for logging errors. Also > remove square brackets [] and additional new line characters in printed > messages. > > Signed-off-by: Krzysztof Kozlowski > --- I don't see a 0/3 cover letter. When sendin

[Qemu-devel] [PATCH 1/3] hw/arm/exynos: Convert fprintf to error_report()

2017-03-05 Thread Krzysztof Kozlowski
error_report() is preferred over fprintf() for logging errors. Also remove square brackets [] and additional new line characters in printed messages. Signed-off-by: Krzysztof Kozlowski --- hw/arm/exynos4_boards.c | 6 +++--- hw/timer/exynos4210_mct.c | 5 +++-- hw/timer/exynos4210_pwm.c | 1