Re: [Qemu-devel] [PATCH 1/3] fixup! libqemustub: add more stubs for qemu-char

2014-06-20 Thread Hu Tao
On Fri, Jun 20, 2014 at 09:26:32AM +0100, Peter Maydell wrote: > On 20 June 2014 06:55, Hu Tao wrote: > > build stub/qemu-chr-open-spice.o only with CONFIG_SPICE, this > > suppresses the warning when building without CONFIG_SPICE. > > I notice there's been a bunch of these "!fixup" patches on > l

Re: [Qemu-devel] [PATCH 1/3] fixup! libqemustub: add more stubs for qemu-char

2014-06-20 Thread Peter Maydell
On 20 June 2014 06:55, Hu Tao wrote: > build stub/qemu-chr-open-spice.o only with CONFIG_SPICE, this > suppresses the warning when building without CONFIG_SPICE. I notice there's been a bunch of these "!fixup" patches on list recently. Do you think you could add something in the subject that says

Re: [Qemu-devel] [PATCH 1/3] fixup! libqemustub: add more stubs for qemu-char

2014-06-19 Thread Hu Tao
On Fri, Jun 20, 2014 at 09:03:59AM +0300, Nikolay Nikolaev wrote: > > > > On Fri, Jun 20, 2014 at 8:55 AM, Hu Tao wrote: > > build stub/qemu-chr-open-spice.o only with CONFIG_SPICE, this > suppresses the warning when building without CONFIG_SPICE. > > Cc: Nikolay Nikolaev > S

Re: [Qemu-devel] [PATCH 1/3] fixup! libqemustub: add more stubs for qemu-char

2014-06-19 Thread Nikolay Nikolaev
On Fri, Jun 20, 2014 at 8:55 AM, Hu Tao wrote: > build stub/qemu-chr-open-spice.o only with CONFIG_SPICE, this > suppresses the warning when building without CONFIG_SPICE. > > Cc: Nikolay Nikolaev > Signed-off-by: Hu Tao > --- > stubs/Makefile.objs | 2 +- > 1 file changed, 1 insertion(+), 1 d

[Qemu-devel] [PATCH 1/3] fixup! libqemustub: add more stubs for qemu-char

2014-06-19 Thread Hu Tao
build stub/qemu-chr-open-spice.o only with CONFIG_SPICE, this suppresses the warning when building without CONFIG_SPICE. Cc: Nikolay Nikolaev Signed-off-by: Hu Tao --- stubs/Makefile.objs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/stubs/Makefile.objs b/stubs/Makefile.ob