Re: [Qemu-devel] [PATCH 1/3] envlist.c: handle strdup failure

2012-05-22 Thread Jim Meyering
Kevin Wolf wrote: > Am 22.05.2012 11:05, schrieb Jim Meyering: >> Kevin Wolf wrote: >>> A patch replacing tabs by spaces isn't really the kind of patches that >>> we would want to avoid during freeze. It's easy enough to check with git >>> diff -w that it doesn't change anything semantically. >> >

Re: [Qemu-devel] [PATCH 1/3] envlist.c: handle strdup failure

2012-05-22 Thread Kevin Wolf
Am 22.05.2012 11:05, schrieb Jim Meyering: > Kevin Wolf wrote: >> A patch replacing tabs by spaces isn't really the kind of patches that >> we would want to avoid during freeze. It's easy enough to check with git >> diff -w that it doesn't change anything semantically. > > That makes sense, so I'v

Re: [Qemu-devel] [PATCH 1/3] envlist.c: handle strdup failure

2012-05-22 Thread Jim Meyering
Kevin Wolf wrote: > A patch replacing tabs by spaces isn't really the kind of patches that > we would want to avoid during freeze. It's easy enough to check with git > diff -w that it doesn't change anything semantically. That makes sense, so I've posted two patches: 1) two patches: one repla

Re: [Qemu-devel] [PATCH 1/3] envlist.c: handle strdup failure

2012-05-22 Thread Kevin Wolf
Am 21.05.2012 19:56, schrieb Blue Swirl: > On Mon, May 21, 2012 at 10:25 AM, Jim Meyering wrote: >> Blue Swirl wrote: >>> On Tue, May 15, 2012 at 1:04 PM, wrote: From: Jim Meyering Without this, envlist_to_environ may silently fail to copy all strings into the destination bu

Re: [Qemu-devel] [PATCH 1/3] envlist.c: handle strdup failure

2012-05-21 Thread Blue Swirl
On Mon, May 21, 2012 at 10:25 AM, Jim Meyering wrote: > Blue Swirl wrote: >> On Tue, May 15, 2012 at 1:04 PM,   wrote: >>> From: Jim Meyering >>> >>> Without this, envlist_to_environ may silently fail to copy all >>> strings into the destination buffer, and both callers would leak >>> any env str

Re: [Qemu-devel] [PATCH 1/3] envlist.c: handle strdup failure

2012-05-21 Thread Jim Meyering
Blue Swirl wrote: > On Tue, May 15, 2012 at 1:04 PM, wrote: >> From: Jim Meyering >> >> Without this, envlist_to_environ may silently fail to copy all >> strings into the destination buffer, and both callers would leak >> any env strings allocated after a failing strdup, because the >> freeing c

Re: [Qemu-devel] [PATCH 1/3] envlist.c: handle strdup failure

2012-05-19 Thread Blue Swirl
On Tue, May 15, 2012 at 1:04 PM, wrote: > From: Jim Meyering > > Without this, envlist_to_environ may silently fail to copy all > strings into the destination buffer, and both callers would leak > any env strings allocated after a failing strdup, because the > freeing code stops at the first NUL

[Qemu-devel] [PATCH 1/3] envlist.c: handle strdup failure

2012-05-15 Thread jim
From: Jim Meyering Without this, envlist_to_environ may silently fail to copy all strings into the destination buffer, and both callers would leak any env strings allocated after a failing strdup, because the freeing code stops at the first NULL pointer. Signed-off-by: Jim Meyering --- envlist