Re: [Qemu-devel] [PATCH 1/3] dataplane/xen-block: remove dead code

2019-02-18 Thread Anthony PERARD
On Fri, Feb 15, 2019 at 09:38:59PM +0100, Philippe Mathieu-Daudé wrote: > On 2/15/19 5:25 PM, Paul Durrant wrote: > > The if() statement is clearly bogus (dead code which should have been > > cleaned up when grant mapping was removed). > > "... was removed in 06454c24ad)." Actually, it looks like

Re: [Qemu-devel] [PATCH 1/3] dataplane/xen-block: remove dead code

2019-02-15 Thread Philippe Mathieu-Daudé
On 2/15/19 5:25 PM, Paul Durrant wrote: > The if() statement is clearly bogus (dead code which should have been > cleaned up when grant mapping was removed). "... was removed in 06454c24ad)." > > Spotted by Coverity: CID 1398635 > > While in the neighbourhood, add a missing 'fall through' annot

[Qemu-devel] [PATCH 1/3] dataplane/xen-block: remove dead code

2019-02-15 Thread Paul Durrant
The if() statement is clearly bogus (dead code which should have been cleaned up when grant mapping was removed). Spotted by Coverity: CID 1398635 While in the neighbourhood, add a missing 'fall through' annotation. Reported-by: Peter Maydell Signed-off-by: Paul Durrant --- Cc: Stefan Hajnoczi