Re: [Qemu-devel] [PATCH 1/3] block: add block_resize monitor command

2011-01-26 Thread Marcelo Tosatti
On Tue, Jan 25, 2011 at 07:05:37PM +0100, Christoph Hellwig wrote: > On Tue, Jan 25, 2011 at 01:01:04PM +0100, Kevin Wolf wrote: > > > Can't resize if block migration is in progress. Don't see a problem > > > with simply disallowing resize in that case. > > > > Then we should add a check to bdrv_

Re: [Qemu-devel] [PATCH 1/3] block: add block_resize monitor command

2011-01-25 Thread Christoph Hellwig
On Tue, Jan 25, 2011 at 01:01:04PM +0100, Kevin Wolf wrote: > > Can't resize if block migration is in progress. Don't see a problem > > with simply disallowing resize in that case. > > Then we should add a check to bdrv_truncate. What check exactly would that be anyway?

Re: [Qemu-devel] [PATCH 1/3] block: add block_resize monitor command

2011-01-25 Thread Kevin Wolf
Am 24.01.2011 18:44, schrieb Marcelo Tosatti: > On Mon, Jan 24, 2011 at 01:32:33PM +0100, Christoph Hellwig wrote: >> Add a monitor command that allows resizing of block devices while >> qemu is running. It uses the existing bdrv_truncate method already >> used by qemu-img to do it's work. Compar

Re: [Qemu-devel] [PATCH 1/3] block: add block_resize monitor command

2011-01-24 Thread Marcelo Tosatti
On Mon, Jan 24, 2011 at 01:32:33PM +0100, Christoph Hellwig wrote: > Add a monitor command that allows resizing of block devices while > qemu is running. It uses the existing bdrv_truncate method already > used by qemu-img to do it's work. Compared to qemu-img the size > parsing is very simplicis

[Qemu-devel] [PATCH 1/3] block: add block_resize monitor command

2011-01-24 Thread Christoph Hellwig
Add a monitor command that allows resizing of block devices while qemu is running. It uses the existing bdrv_truncate method already used by qemu-img to do it's work. Compared to qemu-img the size parsing is very simplicistic, but I think having a properly numering object is more useful for non-h