Re: [Qemu-devel] [PATCH 1/3] block: add bdrv_get_device_or_node_name()

2015-04-08 Thread Eric Blake
On 04/08/2015 03:29 AM, Alberto Garcia wrote: > This function gets the device name associated with a BlockDriverState, > or its node name if the device name is empty. > > Signed-off-by: Alberto Garcia > Reviewed-by: Max Reitz > --- > block.c | 9 + > block/quorum.c

[Qemu-devel] [PATCH 1/3] block: add bdrv_get_device_or_node_name()

2015-04-08 Thread Alberto Garcia
This function gets the device name associated with a BlockDriverState, or its node name if the device name is empty. Signed-off-by: Alberto Garcia Reviewed-by: Max Reitz --- block.c | 9 + block/quorum.c| 5 + include/block/block.h | 1 + 3 files changed, 11 in

Re: [Qemu-devel] [PATCH 1/3] block: add bdrv_get_device_or_node_name()

2015-03-20 Thread Max Reitz
On 2015-03-20 at 10:33, Alberto Garcia wrote: This function gets the device name associated with a BlockDriverState, or its node name if the device name is empty. Signed-off-by: Alberto Garcia --- block.c | 9 + block/quorum.c| 5 + include/block/block.h |

[Qemu-devel] [PATCH 1/3] block: add bdrv_get_device_or_node_name()

2015-03-20 Thread Alberto Garcia
This function gets the device name associated with a BlockDriverState, or its node name if the device name is empty. Signed-off-by: Alberto Garcia --- block.c | 9 + block/quorum.c| 5 + include/block/block.h | 1 + 3 files changed, 11 insertions(+), 4 deletions

Re: [Qemu-devel] [PATCH 1/3] block: add bdrv_get_device_or_node_name()

2015-03-20 Thread Max Reitz
On 2015-03-20 at 06:19, Alberto Garcia wrote: This function gets the device name associated with a BlockDriverState, or its node name if the device name is empty. Signed-off-by: Alberto Garcia --- block.c | 9 + block/quorum.c| 5 + include/block/block.h |

[Qemu-devel] [PATCH 1/3] block: add bdrv_get_device_or_node_name()

2015-03-20 Thread Alberto Garcia
This function gets the device name associated with a BlockDriverState, or its node name if the device name is empty. Signed-off-by: Alberto Garcia --- block.c | 9 + block/quorum.c| 5 + include/block/block.h | 1 + 3 files changed, 11 insertions(+), 4 deletions

Re: [Qemu-devel] [PATCH 1/3] block: add bdrv_get_device_or_node_name()

2015-03-20 Thread Markus Armbruster
Alberto Garcia writes: > On Fri, Mar 20, 2015 at 08:40:32AM +0100, Markus Armbruster wrote: > >> > +const char *bdrv_get_device_or_node_name(const BlockDriverState *bs) >> > +{ >> > +return bs->blk ? blk_name(bs->blk) : bs->node_name; >> > +} >> > + >> >> Does this have uses beyond identifyi

Re: [Qemu-devel] [PATCH 1/3] block: add bdrv_get_device_or_node_name()

2015-03-20 Thread Alberto Garcia
On Fri, Mar 20, 2015 at 08:40:32AM +0100, Markus Armbruster wrote: > > +const char *bdrv_get_device_or_node_name(const BlockDriverState *bs) > > +{ > > +return bs->blk ? blk_name(bs->blk) : bs->node_name; > > +} > > + > > Does this have uses beyond identifying @bs to the user? None that I ca

Re: [Qemu-devel] [PATCH 1/3] block: add bdrv_get_device_or_node_name()

2015-03-20 Thread Markus Armbruster
Alberto Garcia writes: > This function gets the device name associated with a BlockDriverState, > or its node name if the device name is empty. > > Signed-off-by: Alberto Garcia > --- > block.c | 5 + > block/quorum.c| 5 + > include/block/block.h | 1 + > 3 files

Re: [Qemu-devel] [PATCH 1/3] block: add bdrv_get_device_or_node_name()

2015-03-19 Thread Max Reitz
On 2015-03-19 at 11:43, Alberto Garcia wrote: This function gets the device name associated with a BlockDriverState, or its node name if the device name is empty. Signed-off-by: Alberto Garcia --- block.c | 5 + block/quorum.c| 5 + include/block/block.h | 1 +

[Qemu-devel] [PATCH 1/3] block: add bdrv_get_device_or_node_name()

2015-03-19 Thread Alberto Garcia
This function gets the device name associated with a BlockDriverState, or its node name if the device name is empty. Signed-off-by: Alberto Garcia --- block.c | 5 + block/quorum.c| 5 + include/block/block.h | 1 + 3 files changed, 7 insertions(+), 4 deletions(-)