Re: [Qemu-devel] [PATCH 1/3] block/backup: make backup cluster size configurable

2016-02-16 Thread John Snow
On 02/14/2016 01:46 AM, Fam Zheng wrote: > On Fri, 02/12 18:06, John Snow wrote: >> typedef struct CowRequest { >> @@ -46,6 +43,8 @@ typedef struct BackupBlockJob { >> CoRwlock flush_rwlock; >> uint64_t sectors_read; >> HBitmap *bitmap; >> +int64_t cluster_size; >> +int64_

Re: [Qemu-devel] [PATCH 1/3] block/backup: make backup cluster size configurable

2016-02-13 Thread Fam Zheng
On Fri, 02/12 18:06, John Snow wrote: > typedef struct CowRequest { > @@ -46,6 +43,8 @@ typedef struct BackupBlockJob { > CoRwlock flush_rwlock; > uint64_t sectors_read; > HBitmap *bitmap; > +int64_t cluster_size; > +int64_t sectors_per_cluster; I don't think it makes sense

[Qemu-devel] [PATCH 1/3] block/backup: make backup cluster size configurable

2016-02-12 Thread John Snow
64K might not always be appropriate, make this a runtime value. Signed-off-by: John Snow --- block/backup.c | 57 + 1 file changed, 29 insertions(+), 28 deletions(-) diff --git a/block/backup.c b/block/backup.c index 00cafdb..fcf0043 10064