Re: [Qemu-devel] [PATCH 1/3] block/backup: deal with zero detection

2019-08-01 Thread Max Reitz
On 30.07.19 20:40, John Snow wrote: > > > On 7/30/19 12:32 PM, Vladimir Sementsov-Ogievskiy wrote: >> We have detect_zeroes option, so at least for blockdev-backup user >> should define it if zero-detection is needed. For drive-backup leave >> detection enabled by default but do it through existi

Re: [Qemu-devel] [PATCH 1/3] block/backup: deal with zero detection

2019-08-01 Thread Max Reitz
On 30.07.19 18:32, Vladimir Sementsov-Ogievskiy wrote: > We have detect_zeroes option, so at least for blockdev-backup user > should define it if zero-detection is needed. For drive-backup leave > detection enabled by default but do it through existing option instead > of open-coding. > > Signed-o

Re: [Qemu-devel] [PATCH 1/3] block/backup: deal with zero detection

2019-07-31 Thread John Snow
On 7/31/19 6:01 AM, Vladimir Sementsov-Ogievskiy wrote: > 30.07.2019 21:40, John Snow wrote: >> >> >> On 7/30/19 12:32 PM, Vladimir Sementsov-Ogievskiy wrote: >>> We have detect_zeroes option, so at least for blockdev-backup user >>> should define it if zero-detection is needed. For drive-backup

Re: [Qemu-devel] [PATCH 1/3] block/backup: deal with zero detection

2019-07-31 Thread Vladimir Sementsov-Ogievskiy
30.07.2019 21:40, John Snow wrote: > > > On 7/30/19 12:32 PM, Vladimir Sementsov-Ogievskiy wrote: >> We have detect_zeroes option, so at least for blockdev-backup user >> should define it if zero-detection is needed. For drive-backup leave >> detection enabled by default but do it through existin

Re: [Qemu-devel] [PATCH 1/3] block/backup: deal with zero detection

2019-07-30 Thread John Snow
On 7/30/19 12:32 PM, Vladimir Sementsov-Ogievskiy wrote: > We have detect_zeroes option, so at least for blockdev-backup user > should define it if zero-detection is needed. For drive-backup leave > detection enabled by default but do it through existing option instead > of open-coding. > > Sig

[Qemu-devel] [PATCH 1/3] block/backup: deal with zero detection

2019-07-30 Thread Vladimir Sementsov-Ogievskiy
We have detect_zeroes option, so at least for blockdev-backup user should define it if zero-detection is needed. For drive-backup leave detection enabled by default but do it through existing option instead of open-coding. Signed-off-by: Vladimir Sementsov-Ogievskiy --- block/backup.c | 15 +