Next commit will re-enable balloon stats with a different interface, but
this old code conflicts with it. Let's drop it.
It's important to note that the QMP and HMP interfaces are also dropped
by this commit. That shouldn't be a problem though, because:
1. All QMP fields are optional
2. This fe
On 01/18/2013 12:29 PM, Luiz Capitulino wrote:
> Next commit will re-enable balloon stats with a different interface, but
> this old code conflicts with it. Let's drop it.
>
> It's important to note that the QMP and HMP interfaces are also dropped
> by this commit. That shouldn't be a problem thou
Next commit will re-enable balloon stats with a different interface, but
this old code conflicts with it. Let's drop it.
It's important to note that the QMP and HMP interfaces are also dropped
by this commit. That shouldn't be a problem though, because:
1. All QMP fields are optional
2. This fe
On 12/19/2012 04:27 AM, Luiz Capitulino wrote:
>> Libvirt has been using it when available (although reluctantly, as it
>> risks hanging on an uncooperative guest);
>
> This has always been disabled and qemu never returns the stats info.
> I believe libvirt's code is rotting just like qemu's is.
On Tue, 18 Dec 2012 14:34:16 -0700
Eric Blake wrote:
> On 12/17/2012 03:13 AM, Dietmar Maurer wrote:
> >> Next commit will re-enable balloon stats with a different interface, but
> >> this
> >> old code conflicts with it. Let's drop it.
> >
> > I don't really see any conflicts here?
> >
> >> I
> Libvirt has been using it when available (although reluctantly, as it risks
> hanging on an uncooperative guest); and while libvirt can be patched to call 6
> QOM commands in a row to query six different QOM stats, I still think it
> would be nicer to add a command that provides all the stats at
On 12/17/2012 03:13 AM, Dietmar Maurer wrote:
>> Next commit will re-enable balloon stats with a different interface, but this
>> old code conflicts with it. Let's drop it.
>
> I don't really see any conflicts here?
>
>> It's important to note that the QMP and HMP interfaces are also dropped by
>
On Mon, 17 Dec 2012 12:36:59 +
Dietmar Maurer wrote:
> > > There is no code to reset stats inside virtio_balloon_stat()
> >
> > static void virtio_balloon_stat(void *opaque, BalloonInfo *info) {
> > VirtIOBalloon *dev = opaque;
> >
> > #if 0
> > /* Disable guest-provided stats for n
> > There is no code to reset stats inside virtio_balloon_stat()
>
> static void virtio_balloon_stat(void *opaque, BalloonInfo *info) {
> VirtIOBalloon *dev = opaque;
>
> #if 0
> /* Disable guest-provided stats for now. For more details please check:
> * https://bugzilla.redhat.com/s
On Mon, 17 Dec 2012 12:23:59 +
Dietmar Maurer wrote:
> > > I don't really see any conflicts here?
> >
> > query-balloon resets all stats to -1. So, if it's issued after the stats
> > have been
> > polled all values are lost.
>
> I can't see that in the code. I also tested with my patch, an
> > I don't really see any conflicts here?
>
> query-balloon resets all stats to -1. So, if it's issued after the stats have
> been
> polled all values are lost.
I can't see that in the code. I also tested with my patch, and it does not reset
any stats. So I can't see that conflict?
There is no
On Mon, 17 Dec 2012 10:13:40 +
Dietmar Maurer wrote:
> > Next commit will re-enable balloon stats with a different interface, but
> > this
> > old code conflicts with it. Let's drop it.
>
> I don't really see any conflicts here?
query-balloon resets all stats to -1. So, if it's issued afte
> Next commit will re-enable balloon stats with a different interface, but this
> old code conflicts with it. Let's drop it.
I don't really see any conflicts here?
> It's important to note that the QMP and HMP interfaces are also dropped by
> this commit. That shouldn't be a problem though, becau
Next commit will re-enable balloon stats with a different interface, but
this old code conflicts with it. Let's drop it.
It's important to note that the QMP and HMP interfaces are also dropped
by this commit. That shouldn't be a problem though, because:
1. All QMP fields are optional
2. This ha
14 matches
Mail list logo
