Re: [Qemu-devel] [PATCH 1/3] ahci: trim signatures on raise/lower

2018-05-31 Thread John Snow
On 05/31/2018 10:56 AM, Eric Blake wrote: > On 05/30/2018 07:43 PM, John Snow wrote: >> These functions work on the AHCI device, not the individual > > s/device/state/ ? > It's confusing; the AHCI device itself (the HBA) is represented by the struct AHCIState. the SATA devices are referred to

Re: [Qemu-devel] [PATCH 1/3] ahci: trim signatures on raise/lower

2018-05-31 Thread Eric Blake
On 05/30/2018 07:43 PM, John Snow wrote: These functions work on the AHCI device, not the individual s/device/state/ ? AHCI devices, so trim the AHCIDevice argument. Signed-off-by: John Snow --- hw/ide/ahci.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) -- Eric Blake,

[Qemu-devel] [PATCH 1/3] ahci: trim signatures on raise/lower

2018-05-30 Thread John Snow
These functions work on the AHCI device, not the individual AHCI devices, so trim the AHCIDevice argument. Signed-off-by: John Snow --- hw/ide/ahci.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/hw/ide/ahci.c b/hw/ide/ahci.c index e22d7be05f..b7a6f68790 100644 ---