Re: [Qemu-devel] [PATCH 1/3] Add TPM 1.2 host device passthrough interface

2010-08-26 Thread Anthony Liguori
On 08/26/2010 04:44 PM, malc wrote: and lastly there is no errx[1] [..snip..] [1] err(3): CONFORMING TO These functions are non-standard BSD extensions. err() and errx() are already used somewhere. But these should be converted to error_report etc., like other printf b

Re: [Qemu-devel] [PATCH 1/3] Add TPM 1.2 host device passthrough interface

2010-08-26 Thread malc
On Thu, 26 Aug 2010, Blue Swirl wrote: > On Wed, Aug 25, 2010 at 8:46 PM, malc wrote: > > On Wed, 25 Aug 2010, Blue Swirl wrote: > > > >> On Wed, Aug 25, 2010 at 4:33 PM, Andreas Niederl > >> wrote: > >> > This implementation is based on the TPM 1.2 interface for virtualized TPM > >> > devices f

Re: [Qemu-devel] [PATCH 1/3] Add TPM 1.2 host device passthrough interface

2010-08-26 Thread Blue Swirl
On Wed, Aug 25, 2010 at 8:46 PM, malc wrote: > On Wed, 25 Aug 2010, Blue Swirl wrote: > >> On Wed, Aug 25, 2010 at 4:33 PM, Andreas Niederl >> wrote: >> > This implementation is based on the TPM 1.2 interface for virtualized TPM >> > devices from the Xen-4.0.0 ioemu-qemu-xen fork. >> > >> > A sep

Re: [Qemu-devel] [PATCH 1/3] Add TPM 1.2 host device passthrough interface

2010-08-25 Thread malc
On Wed, 25 Aug 2010, Blue Swirl wrote: > On Wed, Aug 25, 2010 at 4:33 PM, Andreas Niederl > wrote: > > This implementation is based on the TPM 1.2 interface for virtualized TPM > > devices from the Xen-4.0.0 ioemu-qemu-xen fork. > > > > A separate thread is used for I/O to the host TPM device bec

Re: [Qemu-devel] [PATCH 1/3] Add TPM 1.2 host device passthrough interface

2010-08-25 Thread Blue Swirl
On Wed, Aug 25, 2010 at 4:33 PM, Andreas Niederl wrote: > This implementation is based on the TPM 1.2 interface for virtualized TPM > devices from the Xen-4.0.0 ioemu-qemu-xen fork. > > A separate thread is used for I/O to the host TPM device because the Linux TPM > driver does not allow for non-b

Re: [Qemu-devel] [PATCH 1/3] Add TPM 1.2 host device passthrough interface

2010-08-25 Thread Anthony Liguori
On 08/25/2010 11:33 AM, Andreas Niederl wrote: This implementation is based on the TPM 1.2 interface for virtualized TPM devices from the Xen-4.0.0 ioemu-qemu-xen fork. A separate thread is used for I/O to the host TPM device because the Linux TPM driver does not allow for non-blocking I/O. Sig

[Qemu-devel] [PATCH 1/3] Add TPM 1.2 host device passthrough interface

2010-08-25 Thread Andreas Niederl
This implementation is based on the TPM 1.2 interface for virtualized TPM devices from the Xen-4.0.0 ioemu-qemu-xen fork. A separate thread is used for I/O to the host TPM device because the Linux TPM driver does not allow for non-blocking I/O. Signed-off-by: Andreas Niederl --- Makefile.target