Re: [Qemu-devel] [PATCH 1/3] 9pfs-proxy: simplify error handling

2015-03-11 Thread Michael Tokarev
11.03.2015 23:05, Michael Tokarev wrote: > I sent a v3 (last) with correct version number, it has just 3 (rather > big) patches: http://thread.gmane.org/gmane.comp.emulators.qemu/324157 . And this is what I think should be done (part of that thread), at least for the proxy code: http://article.gma

Re: [Qemu-devel] [PATCH 1/3] 9pfs-proxy: simplify error handling

2015-03-11 Thread Michael Tokarev
11.03.2015 11:46, Aneesh Kumar K.V wrote: [] > ... Rather than saying > >"Oh well. I've no idea how this code has been accepted. >It is absolute crap." > > it would be nice if we take up specific issues, w.r.t the os/cpu > combination where we are running into issues, we may be able to f

Re: [Qemu-devel] [PATCH 1/3] 9pfs-proxy: simplify error handling

2015-03-11 Thread Aneesh Kumar K.V
Michael Tokarev writes: > 10.03.2015 20:41, Aneesh Kumar K.V пишет: >> Michael Tokarev writes: >> >>> 08.03.2015 19:27, Aneesh Kumar K.V wrote: Michael Tokarev writes: >>> [] > Actually, after reading almost whole 9pfs and fsdev code, I can > say with great confidence this code is

Re: [Qemu-devel] [PATCH 1/3] 9pfs-proxy: simplify error handling

2015-03-10 Thread Michael Tokarev
10.03.2015 20:41, Aneesh Kumar K.V пишет: > Michael Tokarev writes: > >> 08.03.2015 19:27, Aneesh Kumar K.V wrote: >>> Michael Tokarev writes: >> [] Actually, after reading almost whole 9pfs and fsdev code, I can say with great confidence this code is nearly hopeless. >>> >>> Is that a

Re: [Qemu-devel] [PATCH 1/3] 9pfs-proxy: simplify error handling

2015-03-10 Thread Aneesh Kumar K.V
Michael Tokarev writes: > 08.03.2015 19:27, Aneesh Kumar K.V wrote: >> Michael Tokarev writes: > [] >>> Actually, after reading almost whole 9pfs and fsdev code, I can >>> say with great confidence this code is nearly hopeless. >> >> Is that about the 9pfs-proxy code, or the rest of 9pfs. I und

Re: [Qemu-devel] [PATCH 1/3] 9pfs-proxy: simplify error handling

2015-03-09 Thread Michael Tokarev
08.03.2015 19:27, Aneesh Kumar K.V wrote: > Michael Tokarev writes: [] >> Actually, after reading almost whole 9pfs and fsdev code, I can >> say with great confidence this code is nearly hopeless. > > Is that about the 9pfs-proxy code, or the rest of 9pfs. I understand Well. the marshal/unmarsha

Re: [Qemu-devel] [PATCH 1/3] 9pfs-proxy: simplify error handling

2015-03-08 Thread Aneesh Kumar K.V
Michael Tokarev writes: > 07.03.2015 23:37, Eric Blake wrote: >> On 03/06/2015 02:43 PM, Michael Tokarev wrote: >>> All filesystem methods that call common v9fs_request() function >>> also convert return value to errno. Move this conversion to the >>> common function and remove redundand error h

Re: [Qemu-devel] [PATCH 1/3] 9pfs-proxy: simplify error handling

2015-03-08 Thread Aneesh Kumar K.V
Michael Tokarev writes: > All filesystem methods that call common v9fs_request() function > also convert return value to errno. Move this conversion to the > common function and remove redundand error handling in methods. > > I didn't remove local `retval' variable in simple functions to > keep

Re: [Qemu-devel] [PATCH 1/3] 9pfs-proxy: simplify error handling

2015-03-07 Thread Michael Tokarev
08.03.2015 01:10, Michael Tokarev wrote: [] > Heh. Is this all that I can say about this patch? ;) s/I/you/ ofcourse ;) /mjt

Re: [Qemu-devel] [PATCH 1/3] 9pfs-proxy: simplify error handling

2015-03-07 Thread Michael Tokarev
07.03.2015 23:37, Eric Blake wrote: > On 03/06/2015 02:43 PM, Michael Tokarev wrote: >> All filesystem methods that call common v9fs_request() function >> also convert return value to errno. Move this conversion to the >> common function and remove redundand error handling in methods. > > s/redun

Re: [Qemu-devel] [PATCH 1/3] 9pfs-proxy: simplify error handling

2015-03-07 Thread Eric Blake
On 03/06/2015 02:43 PM, Michael Tokarev wrote: > All filesystem methods that call common v9fs_request() function > also convert return value to errno. Move this conversion to the > common function and remove redundand error handling in methods. s/redundand/redundant/ -- Eric Blake eblake redh

[Qemu-devel] [PATCH 1/3] 9pfs-proxy: simplify error handling

2015-03-06 Thread Michael Tokarev
All filesystem methods that call common v9fs_request() function also convert return value to errno. Move this conversion to the common function and remove redundand error handling in methods. I didn't remove local `retval' variable in simple functions to keep the code consistent. Also, proxy_tru