Re: [Qemu-devel] [PATCH 1/2] virtio: Use global memory barrier macros

2011-10-02 Thread Michael S. Tsirkin
On Tue, Sep 20, 2011 at 12:05:20PM +1000, David Gibson wrote: > The virtio code uses wmb() macros in several places, as required by the > SMP-aware virtio protocol. However the wmb() macro is locally defined > to be a compiler barrier only. This is probably sufficient on x86 > due to its strong s

Re: [Qemu-devel] [PATCH 1/2] virtio: Use global memory barrier macros

2011-09-23 Thread Anthony Liguori
On 09/19/2011 09:05 PM, David Gibson wrote: The virtio code uses wmb() macros in several places, as required by the SMP-aware virtio protocol. However the wmb() macro is locally defined to be a compiler barrier only. This is probably sufficient on x86 due to its strong storage ordering model, b

[Qemu-devel] [PATCH 1/2] virtio: Use global memory barrier macros

2011-09-19 Thread David Gibson
The virtio code uses wmb() macros in several places, as required by the SMP-aware virtio protocol. However the wmb() macro is locally defined to be a compiler barrier only. This is probably sufficient on x86 due to its strong storage ordering model, but it certainly isn't on other platforms, such