Re: [Qemu-devel] [PATCH 1/2] util: introduce bitmap_try_new

2014-09-05 Thread Eric Blake
On 09/05/2014 02:00 PM, Peter Lieven wrote: >>> + >> What you have works, but I personally would have reimplemented >> bitmap_new as the first caller of bitmap_try_new in this patch, where >> bitmap_new handles a NULL bitmap_try_new return by abort()ing, so that >> it has the same behavior. By ro

Re: [Qemu-devel] [PATCH 1/2] util: introduce bitmap_try_new

2014-09-05 Thread Peter Lieven
Am 25.08.2014 um 17:09 schrieb Eric Blake: > On 08/22/2014 03:26 AM, Peter Lieven wrote: >> regular bitmap_new simply aborts if the memory allocation fails. >> bitmap_try_new returns NULL on failure and allows for proper >> error handling. >> >> Signed-off-by: Peter Lieven >> --- >> include/qemu/

Re: [Qemu-devel] [PATCH 1/2] util: introduce bitmap_try_new

2014-08-25 Thread Eric Blake
On 08/22/2014 03:26 AM, Peter Lieven wrote: > regular bitmap_new simply aborts if the memory allocation fails. > bitmap_try_new returns NULL on failure and allows for proper > error handling. > > Signed-off-by: Peter Lieven > --- > include/qemu/bitmap.h |6 ++ > 1 file changed, 6 inserti

[Qemu-devel] [PATCH 1/2] util: introduce bitmap_try_new

2014-08-22 Thread Peter Lieven
regular bitmap_new simply aborts if the memory allocation fails. bitmap_try_new returns NULL on failure and allows for proper error handling. Signed-off-by: Peter Lieven --- include/qemu/bitmap.h |6 ++ 1 file changed, 6 insertions(+) diff --git a/include/qemu/bitmap.h b/include/qemu/bi