Re: [Qemu-devel] [PATCH 1/2] usb-ehci: replace PORTSC macros with variables

2013-01-29 Thread Gerd Hoffmann
On 01/29/13 07:42, Kuo-Jung Su wrote: > Hi Gerd: > > Thanks for reminding me of the usb_ehci_pci_initfn. > > But I have a stupid question... > > Which one do the upcoming path v2 looks like ? > > 1. It contains only the diff to usb_ehci_pci_initfn, for example: > > [Qemu-devel][PATCH v

Re: [Qemu-devel] [PATCH 1/2] usb-ehci: replace PORTSC macros with variables

2013-01-29 Thread Andreas Färber
Hi, Am 29.01.2013 07:42, schrieb Kuo-Jung Su: > Thanks for reminding me of the usb_ehci_pci_initfn. > > But I have a stupid question... > > Which one do the upcoming path v2 looks like ? > > 1. It contains only the diff to usb_ehci_pci_initfn, for example: > > [Qemu-devel][PATCH v2 0/1

Re: [Qemu-devel] [PATCH 1/2] usb-ehci: replace PORTSC macros with variables

2013-01-28 Thread Gerd Hoffmann
Hi, > hw/usb/hcd-ehci-sysbus.c |6 ++ > hw/usb/hcd-ehci.c| 21 + > hw/usb/hcd-ehci.h| 12 ++-- > +s->portscbase = sec->portscbase; > +s->portnr = sec->portnr; These two must be initialized in usb_ehci_pci_initfn too. Otherwise th

Re: [Qemu-devel] [PATCH 1/2] usb-ehci: replace PORTSC macros with variables

2013-01-28 Thread Kuo-Jung Su
Hi Gerd: Thanks for reminding me of the usb_ehci_pci_initfn. But I have a stupid question... Which one do the upcoming path v2 looks like ? 1. It contains only the diff to usb_ehci_pci_initfn, for example: [Qemu-devel][PATCH v2 0/1] usb-ehci: add Faraday FUSBH200 support [Qemu-deve

[Qemu-devel] [PATCH 1/2] usb-ehci: replace PORTSC macros with variables

2013-01-28 Thread Kuo-Jung Su
From: Kuo-Jung Su Replace PORTSC macros with variables which could then be configured in ehci__class_init(...) Signed-off-by: Kuo-Jung Su Cc: Gerd Hoffmann Cc: Andreas Cc: Peter Crosthwaite --- hw/usb/hcd-ehci-sysbus.c |6 ++ hw/usb/hcd-ehci.c| 21 +