Re: [Qemu-devel] [PATCH 1/2] tracetool: dtrace: handle in and next reserved words

2012-03-28 Thread Peter Maydell
2012/3/28 Alon Levy : > -        # 'limit' is a reserved keyword > -        if [ "$arg" = "limit" ]; then > -          arg="_limit" > +        # 'limit', 'in' and 'next' are reserved keywords > +        if [ "$arg" = "limit" -o "$arg" = "in" -o "$arg" = "next" ]; then > +          arg="_$arg" >    

Re: [Qemu-devel] [PATCH 1/2] tracetool: dtrace: handle in and next reserved words

2012-03-28 Thread Eric Blake
On 03/28/2012 10:26 AM, Lee Essen wrote: >> +# 'limit', 'in' and 'next' are reserved keywords >> +if [ "$arg" = "limit" -o "$arg" = "in" -o "$arg" = "next" ]; then [ ... -o ... ] is not portable. POSIX says you must break it into: [ ... ] || [ ... ] or, more efficiently for this

Re: [Qemu-devel] [PATCH 1/2] tracetool: dtrace: handle in and next reserved words

2012-03-28 Thread Lee Essen
On 28 Mar 2012, at 15:26, Alon Levy wrote: > Signed-off-by: Alon Levy > --- > scripts/tracetool |6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/scripts/tracetool b/scripts/tracetool > index 65bd0a1..e7cebf3 100755 > --- a/scripts/tracetool > +++ b/scripts/tracet

[Qemu-devel] [PATCH 1/2] tracetool: dtrace: handle in and next reserved words

2012-03-28 Thread Alon Levy
Signed-off-by: Alon Levy --- scripts/tracetool |6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/scripts/tracetool b/scripts/tracetool index 65bd0a1..e7cebf3 100755 --- a/scripts/tracetool +++ b/scripts/tracetool @@ -494,9 +494,9 @@ EOF i=1 for arg in $arglist