Re: [Qemu-devel] [PATCH 1/2] trace: Add simple tracing support

2010-05-21 Thread Anthony Liguori
On 05/21/2010 04:41 PM, Jan Kiszka wrote: Anthony Liguori wrote: I'm not opposed to using a framework, but I'd rather have an equivalent to kvm_stat tomorrow than wait 3 years for LTTng to not get merged. So let's have a dirt-simple tracing mechanism and focus on adding useful trace points.

Re: [Qemu-devel] [PATCH 1/2] trace: Add simple tracing support

2010-05-21 Thread Jan Kiszka
Anthony Liguori wrote: > I'm not opposed to using a framework, but I'd rather have an equivalent > to kvm_stat tomorrow than wait 3 years for LTTng to not get merged. > > So let's have a dirt-simple tracing mechanism and focus on adding useful > trace points. Then when we have a framework we can

Re: [Qemu-devel] [PATCH 1/2] trace: Add simple tracing support

2010-05-21 Thread Jan Kiszka
Stefan Hajnoczi wrote: > On Fri, May 21, 2010 at 5:52 PM, Jan Kiszka wrote: >> I would just like to avoid that too much efforts are spent on >> re-inventing smart trace buffers, trace daemons, or trace visualization >> tools. Then better pick up some semi-perfect approach (e.g. [1], it >> unfortun

Re: [Qemu-devel] [PATCH 1/2] trace: Add simple tracing support

2010-05-21 Thread Christoph Hellwig
On Fri, May 21, 2010 at 09:49:56PM +0100, Stefan Hajnoczi wrote: > http://sourceware.org/systemtap/wiki/AddingUserSpaceProbingToApps > > Requires kernel support - not sure if enough of utrace is in mainline > for this to work out-of-the-box across distros. Nothing of utrace is in mainline, neverm

Re: [Qemu-devel] [PATCH 1/2] trace: Add simple tracing support

2010-05-21 Thread Anthony Liguori
On 05/21/2010 11:52 AM, Jan Kiszka wrote: Anthony Liguori wrote: On 05/21/2010 08:46 AM, Jan Kiszka wrote: Anthony Liguori wrote: On 05/21/2010 04:42 AM, Stefan Hajnoczi wrote: Trace events should be defined in trace.h. Events are written to /tmp/trace.log and c

Re: [Qemu-devel] [PATCH 1/2] trace: Add simple tracing support

2010-05-21 Thread Stefan Hajnoczi
On Fri, May 21, 2010 at 5:52 PM, Jan Kiszka wrote: > I would just like to avoid that too much efforts are spent on > re-inventing smart trace buffers, trace daemons, or trace visualization > tools. Then better pick up some semi-perfect approach (e.g. [1], it > unfortunately still seems to lack ker

Re: [Qemu-devel] [PATCH 1/2] trace: Add simple tracing support

2010-05-21 Thread Jan Kiszka
Anthony Liguori wrote: > On 05/21/2010 08:46 AM, Jan Kiszka wrote: >> Anthony Liguori wrote: >> >>> On 05/21/2010 04:42 AM, Stefan Hajnoczi wrote: >>> Trace events should be defined in trace.h. Events are written to /tmp/trace.log and can be formatted using trace.py. Remember

Re: [Qemu-devel] [PATCH 1/2] trace: Add simple tracing support

2010-05-21 Thread Anthony Liguori
On 05/21/2010 08:46 AM, Jan Kiszka wrote: Anthony Liguori wrote: On 05/21/2010 04:42 AM, Stefan Hajnoczi wrote: Trace events should be defined in trace.h. Events are written to /tmp/trace.log and can be formatted using trace.py. Remember to add events to trace.py for pretty-printing

Re: [Qemu-devel] [PATCH 1/2] trace: Add simple tracing support

2010-05-21 Thread Jan Kiszka
Anthony Liguori wrote: > On 05/21/2010 04:42 AM, Stefan Hajnoczi wrote: >> Trace events should be defined in trace.h. Events are written to >> /tmp/trace.log and can be formatted using trace.py. Remember to add >> events to trace.py for pretty-printing. >> >> Signed-off-by: Stefan Hajnoczi >> ---

Re: [Qemu-devel] [PATCH 1/2] trace: Add simple tracing support

2010-05-21 Thread Anthony Liguori
On 05/21/2010 04:42 AM, Stefan Hajnoczi wrote: Trace events should be defined in trace.h. Events are written to /tmp/trace.log and can be formatted using trace.py. Remember to add events to trace.py for pretty-printing. Signed-off-by: Stefan Hajnoczi --- Makefile.objs |2 +- trace.c

[Qemu-devel] [PATCH 1/2] trace: Add simple tracing support

2010-05-21 Thread Stefan Hajnoczi
Trace events should be defined in trace.h. Events are written to /tmp/trace.log and can be formatted using trace.py. Remember to add events to trace.py for pretty-printing. Signed-off-by: Stefan Hajnoczi --- Makefile.objs |2 +- trace.c | 64