Re: [Qemu-devel] [PATCH 1/2] target/openrisc: convert to DisasContextBase

2018-02-21 Thread Richard Henderson
On 02/17/2018 05:32 PM, Emilio G. Cota wrote: > Signed-off-by: Emilio G. Cota > --- > target/openrisc/translate.c | 87 > ++--- > 1 file changed, 43 insertions(+), 44 deletions(-) > > diff --git a/target/openrisc/translate.c b/target/openrisc/translate.c

Re: [Qemu-devel] [PATCH 1/2] target/openrisc: convert to DisasContextBase

2018-02-17 Thread Emilio G. Cota
On Sun, Feb 18, 2018 at 12:10:46 +0900, Stafford Horne wrote: > On Sat, Feb 17, 2018 at 08:32:36PM -0500, Emilio G. Cota wrote: > > Signed-off-by: Emilio G. Cota > This looks ok to me, and thanks for testing. However, I am not so familiar > with > the DisasContextBase. Is this something new? T

Re: [Qemu-devel] [PATCH 1/2] target/openrisc: convert to DisasContextBase

2018-02-17 Thread Stafford Horne
On Sat, Feb 17, 2018 at 08:32:36PM -0500, Emilio G. Cota wrote: > Signed-off-by: Emilio G. Cota Hello, This looks ok to me, and thanks for testing. However, I am not so familiar with the DisasContextBase. Is this something new? It would be good to have a commit message to say what it is any w

[Qemu-devel] [PATCH 1/2] target/openrisc: convert to DisasContextBase

2018-02-17 Thread Emilio G. Cota
Signed-off-by: Emilio G. Cota --- target/openrisc/translate.c | 87 ++--- 1 file changed, 43 insertions(+), 44 deletions(-) diff --git a/target/openrisc/translate.c b/target/openrisc/translate.c index 2747b24..0450144 100644 --- a/target/openrisc/translate