Re: [Qemu-devel] [PATCH 1/2] serial: fix retry logic

2012-04-02 Thread Anthony Liguori
On 04/02/2012 11:18 AM, Stefano Stabellini wrote: On Mon, 2 Apr 2012, Anthony Liguori wrote: I'm not sure if the retry logic has ever worked when not using FIFO mode. I found this while writing a test case although code inspection confirms it is definitely broken. The TSR retry logic will neve

Re: [Qemu-devel] [PATCH 1/2] serial: fix retry logic

2012-04-02 Thread Stefano Stabellini
On Mon, 2 Apr 2012, Anthony Liguori wrote: > I'm not sure if the retry logic has ever worked when not using FIFO mode. I > found this while writing a test case although code inspection confirms it is > definitely broken. > > The TSR retry logic will never actually happen because it is guarded by

[Qemu-devel] [PATCH 1/2] serial: fix retry logic

2012-04-02 Thread Anthony Liguori
I'm not sure if the retry logic has ever worked when not using FIFO mode. I found this while writing a test case although code inspection confirms it is definitely broken. The TSR retry logic will never actually happen because it is guarded by an 'if (s->tsr_rety > 0)' but this is the only place