Re: [Qemu-devel] [PATCH 1/2] seabios: Add Local APIC NMI Structure to ACPI MADT

2011-10-31 Thread Kenji Kaneshige
(2011/10/28 21:48), Jun Koi wrote: 2011/10/28 Kenji Kaneshige: Avi, Jan, Could you comment on these patches? Inject-NMI doesn't work on Windows guest without these patches. sorry but i am really curious here: why Windows still works well even if it desnt see the inject-NMI? or there are stil

Re: [Qemu-devel] [PATCH 1/2] seabios: Add Local APIC NMI Structure to ACPI MADT

2011-10-30 Thread Avi Kivity
On 10/30/2011 04:44 PM, Avi Kivity wrote: > On 10/10/2011 08:06 AM, Lai Jiangshan wrote: > > From: Kenji Kaneshige > > > > ACPI NMI Structure describes LINT pin (LINT0 or LINT1) information to > > which NMI is connected, and it is needed by OS to initialize local APIC. > > > > > > Kevin, can you p

Re: [Qemu-devel] [PATCH 1/2] seabios: Add Local APIC NMI Structure to ACPI MADT

2011-10-30 Thread Avi Kivity
On 10/10/2011 08:06 AM, Lai Jiangshan wrote: > From: Kenji Kaneshige > > ACPI NMI Structure describes LINT pin (LINT0 or LINT1) information to > which NMI is connected, and it is needed by OS to initialize local APIC. > > Kevin, can you please review these patches? -- error compiling committee.

Re: [Qemu-devel] [PATCH 1/2] seabios: Add Local APIC NMI Structure to ACPI MADT

2011-10-28 Thread Jun Koi
2011/10/28 Kenji Kaneshige : > Avi, Jan, > > Could you comment on these patches? > > Inject-NMI doesn't work on Windows guest without these patches. sorry but i am really curious here: why Windows still works well even if it desnt see the inject-NMI? or there are still invisible side-effects that

Re: [Qemu-devel] [PATCH 1/2] seabios: Add Local APIC NMI Structure to ACPI MADT

2011-10-28 Thread Gleb Natapov
On Fri, Oct 28, 2011 at 09:08:18PM +0900, Kenji Kaneshige wrote: > Avi, Jan, > > Could you comment on these patches? > > Inject-NMI doesn't work on Windows guest without these patches. Windows seems > to setup LVT based on ACPI NMI structure information which is missing in > current > seabios. L

Re: [Qemu-devel] [PATCH 1/2] seabios: Add Local APIC NMI Structure to ACPI MADT

2011-10-28 Thread Kenji Kaneshige
Avi, Jan, Could you comment on these patches? Inject-NMI doesn't work on Windows guest without these patches. Windows seems to setup LVT based on ACPI NMI structure information which is missing in current seabios. LVT LINT1 are never unmasked by Windows guest without the patches. Those patches w

[Qemu-devel] [PATCH 1/2] seabios: Add Local APIC NMI Structure to ACPI MADT (was: Re: [PATCH] qemu: Fix inject-nmi)

2011-10-09 Thread Lai Jiangshan
From: Kenji Kaneshige ACPI NMI Structure describes LINT pin (LINT0 or LINT1) information to which NMI is connected, and it is needed by OS to initialize local APIC. Signed-off-by: Kenji Kaneshige Reviewed-by: Lai Jiangshan --- src/acpi.c | 22 -- 1 file changed, 20 inser