Re: [Qemu-devel] [PATCH 1/2] qobject: Use 'bool' for qbool

2015-06-12 Thread Eric Blake
On 06/11/2015 11:35 PM, Markus Armbruster wrote: > Patch looks good to me, but it made me wonder about something. Please > find the question inline. > > Eric Blake writes: > >> We require a C99 compiler, so let's use 'bool' instead of 'int' >> when dealing with boolean values. There are few en

Re: [Qemu-devel] [PATCH 1/2] qobject: Use 'bool' for qbool

2015-06-11 Thread Markus Armbruster
Patch looks good to me, but it made me wonder about something. Please find the question inline. Eric Blake writes: > We require a C99 compiler, so let's use 'bool' instead of 'int' > when dealing with boolean values. There are few enough clients > to fix them all in one pass. > > Signed-off-by

Re: [Qemu-devel] [PATCH 1/2] qobject: Use 'bool' for qbool

2015-05-19 Thread Alberto Garcia
On Sat 16 May 2015 12:24:59 AM CEST, Eric Blake wrote: > We require a C99 compiler, so let's use 'bool' instead of 'int' > when dealing with boolean values. There are few enough clients > to fix them all in one pass. > > Signed-off-by: Eric Blake Reviewed-by: Alberto Garcia Berto

Re: [Qemu-devel] [PATCH 1/2] qobject: Use 'bool' for qbool

2015-05-17 Thread Markus Armbruster
Eric Blake writes: > On 05/16/2015 07:30 AM, Andreas Färber wrote: >> Am 16.05.2015 um 00:24 schrieb Eric Blake: >>> We require a C99 compiler, so let's use 'bool' instead of 'int' >>> when dealing with boolean values. There are few enough clients >>> to fix them all in one pass. >>> >>> Signed-

Re: [Qemu-devel] [PATCH 1/2] qobject: Use 'bool' for qbool

2015-05-16 Thread Eric Blake
On 05/16/2015 07:30 AM, Andreas Färber wrote: > Am 16.05.2015 um 00:24 schrieb Eric Blake: >> We require a C99 compiler, so let's use 'bool' instead of 'int' >> when dealing with boolean values. There are few enough clients >> to fix them all in one pass. >> >> Signed-off-by: Eric Blake >> --- >

Re: [Qemu-devel] [PATCH 1/2] qobject: Use 'bool' for qbool

2015-05-16 Thread Andreas Färber
Am 16.05.2015 um 00:24 schrieb Eric Blake: > We require a C99 compiler, so let's use 'bool' instead of 'int' > when dealing with boolean values. There are few enough clients > to fix them all in one pass. > > Signed-off-by: Eric Blake > --- > block/qapi.c| 2 +- > block/quo

[Qemu-devel] [PATCH 1/2] qobject: Use 'bool' for qbool

2015-05-15 Thread Eric Blake
We require a C99 compiler, so let's use 'bool' instead of 'int' when dealing with boolean values. There are few enough clients to fix them all in one pass. Signed-off-by: Eric Blake --- block/qapi.c| 2 +- block/quorum.c | 4 ++-- block/vvfat.c