Re: [Qemu-devel] [PATCH 1/2] qmp: Add query-qemu-features

2019-03-30 Thread Markus Armbruster
Kevin Wolf writes: > Am 29.03.2019 um 16:06 hat Eric Blake geschrieben: >> On 3/29/19 8:52 AM, Markus Armbruster wrote: >> > Subjective summary: >> > >> > * For the known use cases, query-qemu-features is merely a crutch for >> > getting information into the QAPI QMP schema. Such crutches are

Re: [Qemu-devel] [PATCH 1/2] qmp: Add query-qemu-features

2019-03-29 Thread Kevin Wolf
Am 29.03.2019 um 16:06 hat Eric Blake geschrieben: > On 3/29/19 8:52 AM, Markus Armbruster wrote: > > Subjective summary: > > > > * For the known use cases, query-qemu-features is merely a crutch for > > getting information into the QAPI QMP schema. Such crutches are ugly, > > but in absence

Re: [Qemu-devel] [PATCH 1/2] qmp: Add query-qemu-features

2019-03-29 Thread Markus Armbruster
Eric Blake writes: > On 3/29/19 8:52 AM, Markus Armbruster wrote: > >> The basic idea is simple. Let me explain with an example. >> >> Instead of what I proposed above: >> >> { 'union': 'BlockdevOptions', >>'base': { 'driver': 'BlockdevDriver', >> '*node-name': 's

Re: [Qemu-devel] [PATCH 1/2] qmp: Add query-qemu-features

2019-03-29 Thread Markus Armbruster
Kevin Wolf writes: > From: Stefan Hajnoczi > > QMP clients can usually detect the presence of features via schema > introspection. There are rare features that do not involve schema > changes and are therefore impossible to detect with schema > introspection. > > This patch adds the query-qemu-

Re: [Qemu-devel] [PATCH 1/2] qmp: Add query-qemu-features

2019-03-29 Thread Eric Blake
On 3/29/19 8:52 AM, Markus Armbruster wrote: > The basic idea is simple. Let me explain with an example. > > Instead of what I proposed above: > > { 'union': 'BlockdevOptions', >'base': { 'driver': 'BlockdevDriver', > '*node-name': 'str', > '*disca

Re: [Qemu-devel] [PATCH 1/2] qmp: Add query-qemu-features

2019-03-29 Thread Markus Armbruster
Eric Blake writes: > On 3/28/19 1:28 PM, Kevin Wolf wrote: >> From: Stefan Hajnoczi >> >> QMP clients can usually detect the presence of features via schema >> introspection. There are rare features that do not involve schema >> changes and are therefore impossible to detect with schema >> int

Re: [Qemu-devel] [PATCH 1/2] qmp: Add query-qemu-features

2019-03-28 Thread Eric Blake
On 3/28/19 1:28 PM, Kevin Wolf wrote: > From: Stefan Hajnoczi > > QMP clients can usually detect the presence of features via schema > introspection. There are rare features that do not involve schema > changes and are therefore impossible to detect with schema > introspection. > > This patch a

[Qemu-devel] [PATCH 1/2] qmp: Add query-qemu-features

2019-03-28 Thread Kevin Wolf
From: Stefan Hajnoczi QMP clients can usually detect the presence of features via schema introspection. There are rare features that do not involve schema changes and are therefore impossible to detect with schema introspection. This patch adds the query-qemu-features command. It returns a stru